Differential D20278

Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort
ClosedPublic
Actions

Authored by epriestley on Mar 12 2019, 3:13 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T10333: Add groups to workboard columns

Commits

rPa6e17fb702d1: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort

Summary

Depends on D20277. Ref T10333.

Put profile icons on "Group by Owner".
Add a similar "Group by Author". Probably not terribly useful, but cheap to implement now.
Add "Sort by Title". Very likely not terribly useful, but cheap to implement and sort of flexible?

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

grip14

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 22256
Build 30437: Run Core Tests
Build 30436: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 12 2019, 3:13 AM

Harbormaster completed remote builds in B22256: Diff 48393.Mar 12 2019, 3:15 AM

epriestley requested review of this revision.Mar 12 2019, 3:15 AM

epriestley added a child revision: D20279: Provide basic scaffolding for workboard column triggers.Mar 12 2019, 6:15 PM

amckinley accepted this revision.Mar 12 2019, 9:29 PM

This revision is now accepted and ready to land.Mar 12 2019, 9:29 PM

Closed by commit rPa6e17fb702d1: Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort (authored by epriestley). · Explain WhyMar 12 2019, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		resources/celerity/map.php (10 lines)
M		src/__phutil_library_map__.php (4 lines)
A	M	src/applications/project/order/PhabricatorProjectColumnAuthorOrder.php (139 lines)
P		src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php (2 lines) Copied to src/applications/project/order/PhabricatorProjectColumnTitleOrder.php
M		src/applications/project/order/PhabricatorProjectColumnHeader.php (7 lines)
M		src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php (12 lines)
M		src/applications/project/order/PhabricatorProjectColumnPointsOrder.php (2 lines)
M		src/applications/project/order/PhabricatorProjectColumnStatusOrder.php (2 lines)
P		src/applications/project/order/PhabricatorProjectColumnTitleOrder.php (13 lines) Copied from src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php
M		webroot/rsrc/css/phui/workboards/phui-workpanel.css (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48393	eac14a8		Mar 12 2019, 3:13 AM	★	★
Diff 2	48417	8d74492	rPa6e17fb702d1de3b6a38ea951bd711f72232f0c2	Mar 12 2019, 9:30 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b0862187c15d	a72053d475a6	eac14a8f6d76	epriestley	WIP	Mar 11 2019, 11:01 PM

Status	Author	Revision
Closed	epriestley	D20288 Hard code a "close task" action on every column Trigger
Closed	epriestley	D20287 Allow triggers to be attached to and removed from workboard columns
Closed	epriestley	D20286 Modularize workboard column transactions
Closed	epriestley	D20281 Make workboard sort-order inversions more clear by using "-1 * ..." instead of "(int)-(int)"
Closed	epriestley	D20279 Provide basic scaffolding for workboard column triggers
Closed	epriestley	D20278 Improve workboard "Owner" grouping, add "Author" grouping and "Title" sort
Closed	epriestley	D20277 Add "Group by Status" to Workboards
Closed	epriestley	D20276 Implement "Sort by Points" on workboards
Closed	epriestley	D20275 Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors
Closed	epriestley	D20274 Provide better UI feedback about cards that can't be dragged or edited
Closed	epriestley	D20273 Allow MFA task edits to go through on workboards
Closed	epriestley	D20272 Improve rendering of empty workboard columns in header views
Closed	epriestley	D20271 When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately
Closed	epriestley	D20270 Implement "Group by Owner" on Workboards
Closed	epriestley	D20269 Modularize workboard column orders
Closed	epriestley	D20268 Add "assert_same_keys()" to "libphutil/"
Closed	epriestley	D20267 Add a "WorkboardCardTemplate" class to make workboard client code easier to reason about
Closed	epriestley	D20266 Remove all readers/writers for task "subpriority"
Closed	epriestley	D20265 On Workboards, sort groups by "natural order", not subpriority
Closed	epriestley	D20263 Remove the ability to drag tasks up and down on (non-Workboard) priority list views