Paths

Table of Contentst

Differential D20013

Make the "Test" adapter support both SMS and email
ClosedPublic
Actions

Authored by epriestley on Jan 21 2019, 11:17 PM.

Tags

None

Referenced Files

	F15531165: D20013.id47812.diff
	Wed, Apr 23, 10:01 AM

	F15516697: D20013.diff
	Fri, Apr 18, 8:47 PM

	F15515470: D20013.id.diff
	Fri, Apr 18, 10:39 AM

	F15515360: D20013.diff
	Fri, Apr 18, 9:51 AM

	F15507376: D20013.diff
	Tue, Apr 15, 7:09 PM

	F15504632: D20013.id47812.diff
	Mon, Apr 14, 7:27 PM

	F15503172: D20013.id47777.diff
	Mon, Apr 14, 7:35 AM

	F15500195: D20013.id.diff
	Sun, Apr 13, 4:40 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T920: Provide SMS Support

Commits

rPf69fbf5ea6d0: Make the "Test" adapter support both SMS and email

Summary

Depends on D20012. Ref T920. If you have a test adapter configured, it should swallow messages and prevent them from ever hitting a lower-priority adapter.

Make the test adapter support SMS so this actually happens.

Test Plan

Ran bin/mail send-test --type sms ... with a test adapter (first) and a Twilio adapter (second). Got SMS swallowed by test adapter instead of live SMS messages.

Diff Detail

Repository

Branch

mfa10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21633
Build 29496: Run Core Tests
Build 29495: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 21 2019, 11:17 PM

Harbormaster completed remote builds in B21633: Diff 47777.Jan 21 2019, 11:19 PM

epriestley requested review of this revision.Jan 21 2019, 11:19 PM

amckinley accepted this revision.Jan 22 2019, 12:08 AM

This revision is now accepted and ready to land.Jan 22 2019, 12:08 AM

epriestley added a child revision: D20016: Correct an issue where the default "Settings" screen could show the wrong settings.Jan 23 2019, 2:46 PM

Closed by commit rPf69fbf5ea6d0: Make the "Test" adapter support both SMS and email (authored by epriestley). · Explain WhyJan 23 2019, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailTestAdapter.php

38 lines

Diff 47777

src/applications/metamta/adapter/PhabricatorMailTestAdapter.php

Loading...