Page MenuHomePhabricator

Give "MetaMTAMail" a "message type" and support SMS
ClosedPublic

Authored by epriestley on Jan 21 2019, 11:12 PM.
Tags
None
Referenced Files
F15407364: D20012.diff
Tue, Mar 18, 5:12 PM
F15390360: D20012.id47776.diff
Sat, Mar 15, 6:09 AM
F15389744: D20012.id47811.diff
Sat, Mar 15, 5:36 AM
F15383253: D20012.diff
Fri, Mar 14, 3:56 PM
Unknown Object (File)
Tue, Feb 25, 4:03 AM
Unknown Object (File)
Mon, Feb 17, 12:08 AM
Unknown Object (File)
Sun, Feb 16, 5:22 PM
Unknown Object (File)
Feb 9 2025, 6:58 AM
Subscribers
None

Details

Summary

Depends on D20011. Ref T920. This change lets a "MetaMTAMail" storage object represent various different types of messages, and makes "all" the bin/mail stuff "totally work" with messages of non-email types.

In practice, a lot of the related tooling needs some polish/refinement, but the basics work.

Test Plan

Used echo beep boop | bin/mail send-test --to epriestley --type sms to send myself SMS.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53

Shouldn't this be impossible? I haven't checked to see if we automatically make the first number added a primary or not, though.

This revision is now accepted and ready to land.Jan 22 2019, 12:08 AM
src/applications/metamta/engine/PhabricatorMailSMSEngine.php
49–53

This one is possible: just don't add any contact numbers to your account.

(Technically, this should become part of whether or not the actor is "deliverable" in a future change, but this is just getting a baseline working.)

The one below is "impossible" but enterprising users can go uPdAtE TaBlE sET ....

This revision was automatically updated to reflect the committed changes.