Page MenuHomePhabricator

Allow tokens to be awarded to MFA-required objects
ClosedPublic

Authored by epriestley on Dec 18 2018, 4:23 PM.

Details

Summary

Depends on D19901. Ref T13222. See PHI873. Currently, the MFA code and the (older, not-really-transactional) token code don't play nicely.

In particular, if the Editor throws we tend to get half an effect applied.

For now, just make this work. Some day it could become more modern so that the transaction actually applies the write.

Test Plan

Awarded and rescinded tokens from an MFA-required object.

Diff Detail

Repository
rP Phabricator
Branch
mfa20
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 21366
Build 29086: Run Core Tests
Build 29085: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 18 2018, 4:23 PM
epriestley requested review of this revision.Dec 18 2018, 4:25 PM
amckinley accepted this revision.Dec 18 2018, 10:46 PM
This revision is now accepted and ready to land.Dec 18 2018, 10:46 PM
This revision was automatically updated to reflect the committed changes.