Differential D19902

Allow tokens to be awarded to MFA-required objects
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 4:23 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rP6a6db0ac8e6f: Allow tokens to be awarded to MFA-required objects

Summary

Depends on D19901. Ref T13222. See PHI873. Currently, the MFA code and the (older, not-really-transactional) token code don't play nicely.

In particular, if the Editor throws we tend to get half an effect applied.

For now, just make this work. Some day it could become more modern so that the transaction actually applies the write.

Test Plan

Awarded and rescinded tokens from an MFA-required object.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 18 2018, 4:23 PM

Harbormaster completed remote builds in B21366: Diff 47512.Dec 18 2018, 4:25 PM

epriestley requested review of this revision.Dec 18 2018, 4:25 PM

epriestley added a child revision: D19903: Allow "bin/auth recover" to generate a link which forces a full login session.Dec 18 2018, 7:17 PM

amckinley accepted this revision.Dec 18 2018, 10:46 PM

This revision is now accepted and ready to land.Dec 18 2018, 10:46 PM

Closed by commit rP6a6db0ac8e6f: Allow tokens to be awarded to MFA-required objects (authored by epriestley). · Explain WhyDec 28 2018, 8:14 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

tokens/

controller/

PhabricatorTokenGiveController.php

4 lines

editor/

PhabricatorTokenGivenEditor.php

72 lines

Diff 47590

View Options

src/applications/tokens/controller/PhabricatorTokenGiveController.php