Page MenuHomePhabricator

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic

Authored by epriestley on Aug 14 2018, 9:49 PM.
Tags
None
Referenced Files
F17953618: D19585.id.diff
Fri, Aug 1, 3:15 AM
F17949304: D19585.id46816.diff
Thu, Jul 31, 11:13 PM
F17948211: D19585.id46839.diff
Thu, Jul 31, 8:22 PM
F17941621: D19585.id.diff
Thu, Jul 31, 5:43 AM
F17923266: D19585.diff
Wed, Jul 30, 7:58 AM
Unknown Object (File)
Jul 1 2025, 11:43 PM
Unknown Object (File)
Jun 29 2025, 7:10 AM
Unknown Object (File)
Jun 4 2025, 8:58 AM
Subscribers
None

Details

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan
  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable