Page MenuHomePhabricator
Differential D19583

Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor
ClosedPublic
Actions

Authored by epriestley on Aug 14 2018, 8:30 PM.
Tags
None
Referenced Files
F18181088: D19583.id46837.diff
Sat, Aug 16, 7:30 AM
F18020723: D19583.diff
Sat, Aug 2, 7:54 PM
Unknown Object (File)
Jul 4 2025, 8:19 AM
Unknown Object (File)
Jul 1 2025, 4:42 PM
Unknown Object (File)
Jun 29 2025, 7:04 PM
Unknown Object (File)
Jun 3 2025, 5:22 AM
Unknown Object (File)
Jun 3 2025, 5:22 AM
Unknown Object (File)
May 27 2025, 7:21 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13164: Plans: 2018 Week 31 - 33 Bonus Content
Commits
rP24d444584548: Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor
Summary

Depends on D19582. Ref T13164. It's not possible to reach the editor without passing through a CAN_EDIT check, and it shouldn't be necessarily to manually specify that edits require CAN_EDIT by default.

Test Plan

Grepped for RepositoryEditor, verified that all callsites pass through a CAN_EDIT check.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
editor/
34 lines

Diff 46837

View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...
Phabricator · Built by Phacility