Differential D19585

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic
Actions

Authored by epriestley on Aug 14 2018, 9:49 PM.

Tags

None

Referenced Files

	F14320724: D19585.diff
	Wed, Dec 18, 11:09 AM

	F14301806: D19585.id46816.diff
	Tue, Dec 17, 6:25 PM

	Unknown Object (File)
	Thu, Dec 12, 7:57 AM

	Unknown Object (File)
	Sun, Dec 8, 6:10 AM

	Unknown Object (File)
	Wed, Dec 4, 1:49 PM

	Unknown Object (File)
	Fri, Nov 29, 8:54 PM

	Unknown Object (File)
	Wed, Nov 20, 8:51 AM

	Unknown Object (File)
	Nov 16 2024, 7:44 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP7e29ec2e2a66: Move the "Can Lock Projects" check from requireCapabilities() to transaction…

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan

This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository

Branch

uxaction7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20616
Build 28014: Run Core Tests
Build 28013: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 14 2018, 9:49 PM

Harbormaster completed remote builds in B20616: Diff 46816.Aug 14 2018, 9:51 PM

epriestley requested review of this revision.Aug 14 2018, 9:51 PM

epriestley added a child revision: D19586: Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default.Aug 14 2018, 11:08 PM

amckinley accepted this revision.Aug 14 2018, 11:50 PM

This revision is now accepted and ready to land.Aug 14 2018, 11:50 PM

epriestley mentioned this in T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.Aug 16 2018, 4:00 PM

epriestley added a child revision: D19592: Give PhabricatorAuthPassword a formal CAN_EDIT policy.Aug 16 2018, 5:12 PM

Closed by commit rP7e29ec2e2a66: Move the "Can Lock Projects" check from requireCapabilities() to transaction… (authored by epriestley). · Explain WhyAug 16 2018, 5:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

6 lines

xaction/

PhabricatorProjectLockTransaction.php

8 lines

transactions/

storage/

PhabricatorModularTransactionType.php

10 lines

Diff 46816

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/xaction/PhabricatorProjectLockTransaction.php

Loading...

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...