Page MenuHomePhabricator

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic

Authored by epriestley on Aug 14 2018, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 4:58 PM
Unknown Object (File)
Sat, Mar 23, 10:21 PM
Unknown Object (File)
Fri, Mar 22, 9:38 PM
Unknown Object (File)
Wed, Mar 20, 2:35 PM
Unknown Object (File)
Wed, Mar 20, 2:26 PM
Unknown Object (File)
Fri, Mar 15, 7:01 PM
Unknown Object (File)
Tue, Mar 12, 8:00 AM
Unknown Object (File)
Sun, Mar 10, 6:22 PM
Subscribers
None

Details

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan
  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable