Page MenuHomePhabricator

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic

Authored by epriestley on Aug 14 2018, 9:49 PM.
Tags
None
Referenced Files
F18637789: D19585.id46816.diff
Wed, Sep 17, 8:42 AM
F18509746: D19585.id.diff
Sep 5 2025, 3:35 AM
F18503148: D19585.diff
Sep 4 2025, 10:52 PM
F18374585: D19585.diff
Aug 28 2025, 8:59 AM
F18371298: D19585.id46839.diff
Aug 28 2025, 4:57 AM
F17953618: D19585.id.diff
Aug 1 2025, 3:15 AM
F17949304: D19585.id46816.diff
Jul 31 2025, 11:13 PM
F17948211: D19585.id46839.diff
Jul 31 2025, 8:22 PM
Subscribers
None

Details

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan
  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable