Page MenuHomePhabricator

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic

Authored by epriestley on Aug 14 2018, 9:49 PM.
Tags
None
Referenced Files
F15560659: D19585.id.diff
Tue, Apr 29, 3:51 PM
F15549630: D19585.id.diff
Sun, Apr 27, 7:00 AM
F15549298: D19585.id.diff
Sun, Apr 27, 4:58 AM
F15544632: D19585.diff
Sat, Apr 26, 6:24 AM
F15513997: D19585.diff
Thu, Apr 17, 11:36 PM
F15504239: D19585.diff
Mon, Apr 14, 4:56 PM
F15465950: D19585.id46816.diff
Apr 3 2025, 12:29 AM
F15439218: D19585.id.diff
Mar 26 2025, 6:22 AM
Subscribers
None

Details

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan
  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable