Page MenuHomePhabricator

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic

Authored by epriestley on Aug 14 2018, 9:49 PM.
Tags
None
Referenced Files
F21176933: D19585.diff
Sat, Jul 4, 7:15 AM
F21176930: D19585.diff
Sat, Jul 4, 7:15 AM
Unknown Object (File)
Tue, Jun 16, 8:30 AM
Unknown Object (File)
Sun, Jun 14, 2:40 AM
Unknown Object (File)
Mar 9 2026, 7:59 PM
Unknown Object (File)
Feb 15 2026, 7:13 PM
Unknown Object (File)
Dec 22 2025, 10:34 PM
Unknown Object (File)
Nov 9 2025, 3:27 PM
Subscribers
None

Details

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan
  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable