Page MenuHomePhabricator

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
ClosedPublic

Authored by epriestley on Aug 14 2018, 9:49 PM.
Tags
None
Referenced Files
F19828605: D19585.id46839.diff
Mar 9 2026, 7:59 PM
F19748594: D19585.diff
Feb 15 2026, 7:13 PM
F19270963: D19585.diff
Dec 22 2025, 10:34 PM
F18922439: D19585.diff
Nov 9 2025, 3:27 PM
F18905212: D19585.diff
Nov 8 2025, 1:18 PM
F18902192: D19585.id46816.diff
Nov 8 2025, 12:09 AM
F18872525: D19585.id.diff
Nov 5 2025, 4:53 AM
F18836997: D19585.diff
Oct 27 2025, 4:08 AM
Subscribers
None

Details

Summary

Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan
  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable