Differential D19582

Remove pointless requireCapabilities() method from PhabricatorProjectColumnTransactionEditor
ClosedPublic
Actions

Authored by epriestley on Aug 14 2018, 8:22 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rPa39852ae1b4a: Remove pointless requireCapabilities() method from…

Summary

Depends on D19581. Ref T13164. This method has no effect:

You must always have CAN_EDIT to reach an Editor in the first place.
Per previous change, I'm going to restructure this so transactions explicitly check CAN_EDIT by default anyway.

Test Plan

Tried to edit and hide a project column as a user without permission, hit global permission checks long before reaching this method.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 14 2018, 8:22 PM

Harbormaster completed remote builds in B20613: Diff 46813.Aug 14 2018, 8:24 PM

epriestley requested review of this revision.Aug 14 2018, 8:24 PM

epriestley added a child revision: D19583: Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor.Aug 14 2018, 8:30 PM

amckinley accepted this revision.Aug 14 2018, 8:30 PM

This revision is now accepted and ready to land.Aug 14 2018, 8:30 PM

epriestley mentioned this in T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.Aug 16 2018, 4:00 PM

Closed by commit rPa39852ae1b4a: Remove pointless requireCapabilities() method from… (authored by epriestley). · Explain WhyAug 16 2018, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectColumnTransactionEditor.php

18 lines

Diff 46836

View Options

src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php

Remove pointless requireCapabilities() method from PhabricatorProjectColumnTransactionEditorClosedPublicActions