Page MenuHomePhabricator

Give PhabricatorAuthPassword a formal CAN_EDIT policy
ClosedPublic

Authored by epriestley on Aug 16 2018, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 5:13 PM
Unknown Object (File)
Fri, Dec 13, 8:36 PM
Unknown Object (File)
Fri, Dec 6, 1:03 PM
Unknown Object (File)
Thu, Nov 28, 2:10 AM
Unknown Object (File)
Sat, Nov 23, 7:57 PM
Unknown Object (File)
Oct 23 2024, 8:53 PM
Unknown Object (File)
Oct 21 2024, 10:39 AM
Unknown Object (File)
Oct 20 2024, 5:00 PM
Subscribers
None

Details

Summary

Depends on D19585. Ref T13164. This is a precursor for D19586, which causes Editors to start doing more explicit CAN_EDIT checks.

Passwords have an Editor, but don't actually define a CAN_EDIT capability. Define one (you can edit a password if you can edit the object the password is associated with).

(Today, this object is always a User -- this table just unified VCS passwords and Account passwords so they can be handled more consistently.)

Test Plan
  • With D19586, ran unit tests and got a pass.
  • Edited my own password.
  • Tried to edit another user's password and wasn't permitted to.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable