Page MenuHomePhabricator

Give PhabricatorAuthPassword a formal CAN_EDIT policy
ClosedPublic

Authored by epriestley on Aug 16 2018, 5:12 PM.
Tags
None
Referenced Files
F18733290: D19592.diff
Tue, Sep 30, 10:25 PM
F18721151: D19592.id.diff
Mon, Sep 29, 8:39 PM
F18693820: D19592.diff
Sat, Sep 27, 2:00 AM
F18670086: D19592.id46830.diff
Wed, Sep 24, 11:00 PM
F18626483: D19592.id46841.diff
Tue, Sep 16, 1:21 AM
F18509750: D19592.id.diff
Sep 5 2025, 3:35 AM
F18503169: D19592.diff
Sep 4 2025, 10:53 PM
F18388440: D19592.id46830.diff
Aug 29 2025, 4:27 AM
Subscribers
None

Details

Summary

Depends on D19585. Ref T13164. This is a precursor for D19586, which causes Editors to start doing more explicit CAN_EDIT checks.

Passwords have an Editor, but don't actually define a CAN_EDIT capability. Define one (you can edit a password if you can edit the object the password is associated with).

(Today, this object is always a User -- this table just unified VCS passwords and Account passwords so they can be handled more consistently.)

Test Plan
  • With D19586, ran unit tests and got a pass.
  • Edited my own password.
  • Tried to edit another user's password and wasn't permitted to.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable