Page MenuHomePhabricator

Give PhabricatorAuthPassword a formal CAN_EDIT policy
ClosedPublic

Authored by epriestley on Aug 16 2018, 5:12 PM.
Tags
None
Referenced Files
F13996398: D19592.id46841.diff
Wed, Oct 23, 8:53 PM
F13987673: D19592.diff
Mon, Oct 21, 10:39 AM
F13984931: D19592.id46841.diff
Sun, Oct 20, 5:00 PM
F13975065: D19592.diff
Oct 18 2024, 8:33 AM
F13970593: D19592.id46830.diff
Oct 17 2024, 8:38 AM
Unknown Object (File)
Oct 9 2024, 9:55 AM
Unknown Object (File)
Oct 1 2024, 5:48 PM
Unknown Object (File)
Oct 1 2024, 10:14 AM
Subscribers
None

Details

Summary

Depends on D19585. Ref T13164. This is a precursor for D19586, which causes Editors to start doing more explicit CAN_EDIT checks.

Passwords have an Editor, but don't actually define a CAN_EDIT capability. Define one (you can edit a password if you can edit the object the password is associated with).

(Today, this object is always a User -- this table just unified VCS passwords and Account passwords so they can be handled more consistently.)

Test Plan
  • With D19586, ran unit tests and got a pass.
  • Edited my own password.
  • Tried to edit another user's password and wasn't permitted to.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable