Allow Almanac Bindings to be enabled/disabled via API and support the "properties" attachment
ClosedPublic
Actions

Authored by epriestley on Apr 11 2018, 2:17 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rPd56a37b63673: Allow Almanac Bindings to be enabled/disabled via API and support the…

Summary

Depends on D19340. Ref T12414. Ref T13120. See T12414 for some discussion about direction here.

Since I think retaining "enabled/disabled" as a simple flag is reasonable, expose it via the API for readers and writers.

Also expose binding properties.

Test Plan

Searched for bindings and properties with "alamanc.binding.search".
Enabled and disabled bindings with "almanac.binding.edit".

Diff Detail

Repository

rP Phabricator

Branch

almanac23

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20075
Build 27236: Run Core Tests
Build 27235: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2018, 2:17 PM

Harbormaster completed remote builds in B20075: Diff 46252.Apr 11 2018, 2:18 PM

epriestley requested review of this revision.Apr 11 2018, 2:18 PM

epriestley added a child revision: D19342: Make various small quality-of-life improvements for Almanac properties.Apr 11 2018, 3:41 PM

amckinley accepted this revision.Apr 11 2018, 3:58 PM

This revision is now accepted and ready to land.Apr 11 2018, 3:58 PM

Closed by commit rPd56a37b63673: Allow Almanac Bindings to be enabled/disabled via API and support the… (authored by epriestley). · Explain WhyApr 11 2018, 5:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

editor/

AlmanacBindingEditEngine.php

13 lines

storage/

AlmanacBinding.php

10 lines

Diff 46252

View Options

src/applications/almanac/editor/AlmanacBindingEditEngine.php