Differential D19338

Implement "almanac.interface.search" and "almanac.interface.edit"
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 7:22 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rPe502df509d5f: Implement "almanac.interface.search" and "almanac.interface.edit"

Summary

Depends on D19337. Ref T13120. Ref T12414. These are slightly more substantive than namespace/network, but pretty much standard fare.

Test Plan

Searched for interfaces with "almanac.interface.search".
Created and edited interfaces with "almanac.interface.edit".
Created and edited interfaces with web UI since some stuff got tweaked.

Diff Detail

Repository

rP Phabricator

Branch

almanac21

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20071
Build 27228: Run Core Tests
Build 27227: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2018, 7:22 PM

Harbormaster completed remote builds in B20071: Diff 46248.Apr 10 2018, 7:23 PM

epriestley requested review of this revision.Apr 10 2018, 7:23 PM

amckinley accepted this revision.Apr 10 2018, 7:35 PM

This revision is now accepted and ready to land.Apr 10 2018, 7:35 PM

epriestley added a child revision: D19340: Provide "almanac.binding.search" and "almanac.binding.edit".Apr 11 2018, 1:40 PM

Closed by commit rPe502df509d5f: Implement "almanac.interface.search" and "almanac.interface.edit" (authored by epriestley). · Explain WhyApr 11 2018, 5:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

9 lines

applications/

almanac/

conduit/

AlmanacInterfaceEditConduitAPIMethod.php

19 lines

AlmanacInterfaceSearchConduitAPIMethod.php

18 lines

editor/

AlmanacInterfaceEditEngine.php

46 lines

query/

AlmanacInterfaceSearchEngine.php

71 lines

storage/

AlmanacInterface.php

41 lines

transactions/

editfield/

PhabricatorIntEditField.php

14 lines

Diff 46248

View Options

src/__phutil_library_map__.php

View Options

src/applications/almanac/conduit/AlmanacInterfaceEditConduitAPIMethod.php

View Options

src/applications/almanac/conduit/AlmanacInterfaceSearchConduitAPIMethod.php

View Options

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

View Options

src/applications/almanac/query/AlmanacInterfaceSearchEngine.php

View Options

src/applications/almanac/storage/AlmanacInterface.php

View Options

src/applications/transactions/editfield/PhabricatorIntEditField.php

Implement "almanac.interface.search" and "almanac.interface.edit"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46248

src/__phutil_library_map__.php

src/applications/almanac/conduit/AlmanacInterfaceEditConduitAPIMethod.php

src/applications/almanac/conduit/AlmanacInterfaceSearchConduitAPIMethod.php

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

src/applications/almanac/query/AlmanacInterfaceSearchEngine.php

src/applications/almanac/storage/AlmanacInterface.php

src/applications/transactions/editfield/PhabricatorIntEditField.php

Implement "almanac.interface.search" and "almanac.interface.edit"
ClosedPublic
Actions

Revision Contents
Changeset List