Page MenuHomePhabricator
Differential D19290

Clean up an old transaction state flag
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 5:00 PM.
Tags
None
Referenced Files
F17704068: D19290.diff
Wed, Jul 16, 3:01 AM
F17650412: D19290.id46156.diff
Sat, Jul 12, 4:31 AM
F17642151: D19290.id46172.diff
Fri, Jul 11, 8:21 PM
Unknown Object (File)
Jun 16 2025, 3:40 PM
Unknown Object (File)
Jun 16 2025, 10:52 AM
Unknown Object (File)
May 31 2025, 4:19 AM
Unknown Object (File)
May 30 2025, 11:26 AM
Unknown Object (File)
May 28 2025, 5:25 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits
rP6f520e053462: Clean up an old transaction state flag
Summary

Depends on D19289. Ref T13110. This flag has been obsolete for some time and has no callers.

Test Plan

Grepped for hasReviewTransaction, no hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 3 2018, 5:00 PM
Harbormaster completed remote builds in B19977: Diff 46156.Apr 3 2018, 5:01 PM
epriestley requested review of this revision.Apr 3 2018, 5:01 PM
epriestley added a child revision: D19291: Move PhabricatorModularTransaction slightly closer to having "final" methods again.Apr 3 2018, 5:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:13 PM
Closed by commit rP6f520e053462: Clean up an old transaction state flag (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
8 lines

Diff 46172

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility