Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 3:11 PM.

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rP3b5a7d1c88c4: Rename the Differential "hasBroadcast" flag to "shouldBroadcast"

Summary

Depends on D19282. Ref T13110. I want to introduce "Changes Planned + Still A Draft" and "Abandoned + Still A Draft" states, at a minimum.

I think the "hasBroadcast" flag is effectively identical to a hypothetical "stillADraft" flag, so rename it to "shouldBroadcast" to better match its intended behavior.

This just changes labels, not any behavior.

Test Plan

Grepped for hasBroadcast and HAS_BROADCAST.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 3 2018, 3:11 PM

Harbormaster completed remote builds in B19970: Diff 46149.Apr 3 2018, 3:12 PM

epriestley requested review of this revision.Apr 3 2018, 3:12 PM

epriestley added a child revision: D19284: Partially decouple revision broadcasting from revision draft state.Apr 3 2018, 3:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:09 PM

Closed by commit rP3b5a7d1c88c4: Rename the Differential "hasBroadcast" flag to "shouldBroadcast" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

4 lines

storage/

DifferentialRevision.php

12 lines

Diff 46165

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php