Page MenuHomePhabricator

Move structural build publishing logic to BuildEngine, provide "bin/harbormaster publish"
ClosedPublic

Authored by epriestley on Apr 3 2018, 1:05 PM.
Tags
None
Referenced Files
F14052686: D19279.diff
Fri, Nov 15, 9:42 AM
F14040187: D19279.diff
Mon, Nov 11, 7:41 AM
F14024599: D19279.diff
Thu, Nov 7, 11:02 AM
Unknown Object (File)
Oct 9 2024, 9:16 AM
Unknown Object (File)
Oct 9 2024, 9:16 AM
Unknown Object (File)
Oct 9 2024, 9:16 AM
Unknown Object (File)
Oct 7 2024, 9:14 PM
Unknown Object (File)
Oct 5 2024, 11:26 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19278. Ref T13110. This moves most of the structural logic for publishing builds to BuildableEngine and provides a bin/harbormaster publish to make publishing easy to retry/debug.

This intentionally removes the bit which actually does anything when builds publish. Followup changes will implement application-specific versions of the publishing logic in Differential and Diffusion.

Test Plan

Ran bin/harbormaster publish Bxxx, saw it do nothing (but not crash).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 3 2018, 1:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 5:58 PM
This revision was automatically updated to reflect the committed changes.