Page MenuHomePhabricator

Move structural build publishing logic to BuildEngine, provide "bin/harbormaster publish"
ClosedPublic

Authored by epriestley on Apr 3 2018, 1:05 PM.
Tags
None
Referenced Files
F15419032: D19279.id.diff
Fri, Mar 21, 2:56 AM
F15404000: D19279.id46161.diff
Tue, Mar 18, 5:50 AM
F15386405: D19279.id46145.diff
Sat, Mar 15, 12:31 AM
F15308282: D19279.diff
Thu, Mar 6, 6:05 AM
Unknown Object (File)
Tue, Feb 25, 9:09 PM
Unknown Object (File)
Sat, Feb 22, 6:06 PM
Unknown Object (File)
Feb 19 2025, 11:00 AM
Unknown Object (File)
Feb 17 2025, 9:25 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19278. Ref T13110. This moves most of the structural logic for publishing builds to BuildableEngine and provides a bin/harbormaster publish to make publishing easy to retry/debug.

This intentionally removes the bit which actually does anything when builds publish. Followup changes will implement application-specific versions of the publishing logic in Differential and Diffusion.

Test Plan

Ran bin/harbormaster publish Bxxx, saw it do nothing (but not crash).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 3 2018, 1:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 5:58 PM
This revision was automatically updated to reflect the committed changes.