Page MenuHomePhabricator

Partially decouple revision broadcasting from revision draft state
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 10:44 PM
Unknown Object (File)
Sun, Nov 17, 10:35 PM
Unknown Object (File)
Thu, Nov 14, 1:29 PM
Unknown Object (File)
Sat, Nov 9, 8:48 PM
Unknown Object (File)
Sat, Nov 9, 12:35 PM
Unknown Object (File)
Tue, Nov 5, 5:18 PM
Unknown Object (File)
Tue, Nov 5, 4:50 AM
Unknown Object (File)
Sat, Nov 2, 6:06 PM
Subscribers
None

Details

Summary

Depends on D19283. Ref T13110. To enable "Changes Planned + But, Still A Draft" and "Abandoned + But, Never Promoted From Draft" states, decouple the "broadcast" flag from the "draft" state.

Broadcast behavior is now based only on the shouldBroadcast flag, and revisions in any state may have this flag.

Revisions gain this flag when created as a non-draft, or when they leave the draft state for the first time.

There are probably still some ways you can get the wrong result here -- maybe abandon + update -- but those can be cleaned up as they arise.

Test Plan

Kinda poked it a bit but I'll vet this more heavily at the end of this sequence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable