Page MenuHomePhabricator

Partially decouple revision broadcasting from revision draft state
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:23 PM.
Tags
None
Referenced Files
F13193840: D19284.diff
Sun, May 12, 6:27 PM
F13188040: D19284.diff
Sat, May 11, 4:56 AM
Unknown Object (File)
Tue, May 7, 8:07 AM
Unknown Object (File)
Fri, May 3, 7:48 AM
Unknown Object (File)
Thu, Apr 25, 2:08 AM
Unknown Object (File)
Wed, Apr 17, 2:54 PM
Unknown Object (File)
Apr 3 2024, 7:47 PM
Unknown Object (File)
Mar 30 2024, 4:30 PM
Subscribers
None

Details

Summary

Depends on D19283. Ref T13110. To enable "Changes Planned + But, Still A Draft" and "Abandoned + But, Never Promoted From Draft" states, decouple the "broadcast" flag from the "draft" state.

Broadcast behavior is now based only on the shouldBroadcast flag, and revisions in any state may have this flag.

Revisions gain this flag when created as a non-draft, or when they leave the draft state for the first time.

There are probably still some ways you can get the wrong result here -- maybe abandon + update -- but those can be cleaned up as they arise.

Test Plan

Kinda poked it a bit but I'll vet this more heavily at the end of this sequence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable