Paths

Table of Contentst

Differential D19290

Clean up an old transaction state flag
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 5:00 PM.

Tags

None

Referenced Files

	F13134873: D19290.diff
	Thu, May 2, 5:44 AM

	Unknown Object (File)
	Wed, May 1, 12:12 AM

	Unknown Object (File)
	Thu, Apr 18, 11:14 AM

	Unknown Object (File)
	Thu, Apr 18, 7:07 AM

	Unknown Object (File)
	Mon, Apr 15, 6:23 PM

	Unknown Object (File)
	Thu, Apr 11, 7:52 PM

	Unknown Object (File)
	Thu, Apr 11, 7:39 PM

	Unknown Object (File)
	Thu, Apr 11, 9:25 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rP6f520e053462: Clean up an old transaction state flag

Summary

Depends on D19289. Ref T13110. This flag has been obsolete for some time and has no callers.

Test Plan

Grepped for hasReviewTransaction, no hits.

Diff Detail

Repository

Branch

bengine13

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19977
Build 27089: Run Core Tests
Build 27088: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 5:00 PM

Harbormaster completed remote builds in B19977: Diff 46156.Apr 3 2018, 5:01 PM

epriestley requested review of this revision.Apr 3 2018, 5:01 PM

epriestley added a child revision: D19291: Move PhabricatorModularTransaction slightly closer to having "final" methods again.Apr 3 2018, 5:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:13 PM

Closed by commit rP6f520e053462: Clean up an old transaction state flag (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

8 lines

Diff 46156

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...