Page MenuHomePhabricator

Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 12:58 AM
Unknown Object (File)
Mon, Dec 30, 12:58 AM
Unknown Object (File)
Sat, Dec 28, 7:38 PM
Unknown Object (File)
Dec 5 2024, 1:55 AM
Unknown Object (File)
Nov 22 2024, 6:58 AM
Unknown Object (File)
Nov 20 2024, 9:51 AM
Unknown Object (File)
Nov 20 2024, 6:27 AM
Unknown Object (File)
Nov 20 2024, 3:30 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19284. Ref T13110. It's now possible to get a revision into a "Abandoned + But, Never Promoted From Draft" state. Show this in the header and provide the draft hint above the comment area.

Also, remove shouldBroadcast(). The method getShouldBroadcast() now has the same meaning.

Finally, migrate existing drafts to shouldBroadcast = false and default shouldBroadcast to true. If we don't do this, every older revision becomes a non-broadcasting revision because this flag was not explicitly set on revision creation before, only on promotion out of draft.

Test Plan

Ran migration; abandoned draft revisions and ended up in a draft + abandoned state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable