Page MenuHomePhabricator

Move PhabricatorModularTransaction slightly closer to having "final" methods again
ClosedPublic

Authored by epriestley on Apr 3 2018, 5:04 PM.
Tags
None
Referenced Files
F19468698: D19291.id.diff
Sun, Jan 4, 8:47 AM
F19019714: D19291.diff
Nov 23 2025, 3:42 PM
F18838143: D19291.diff
Oct 27 2025, 9:27 AM
F18818849: D19291.id.diff
Oct 22 2025, 2:41 AM
F18812092: D19291.diff
Oct 20 2025, 6:52 AM
F18778685: D19291.id46157.diff
Oct 11 2025, 10:25 AM
F18751369: D19291.id46173.diff
Oct 4 2025, 10:43 AM
F18618360: D19291.diff
Sep 14 2025, 11:54 PM
Subscribers
None

Details

Summary

Depends on D19290. Ref T13110. Differential still has some hacks in place which require these methods to "very temporarily" be nonfinal, but the badness can be slightly reduced nowadays.

Test Plan

Loaded some pages, nothing fataled.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:14 PM
This revision was automatically updated to reflect the committed changes.