Page MenuHomePhabricator

When a non-broadcasting revision is updated, put it in "Draft", not "Needs Review"
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:56 PM.
Tags
None
Referenced Files
F18674165: D19286.diff
Thu, Sep 25, 1:28 PM
F18612660: D19286.id46152.diff
Sun, Sep 14, 9:38 AM
F18509500: D19286.id.diff
Sep 5 2025, 3:26 AM
F18502548: D19286.diff
Sep 4 2025, 10:30 PM
F17951486: D19286.id46168.diff
Aug 1 2025, 1:24 AM
F17949100: D19286.id46152.diff
Jul 31 2025, 10:51 PM
F17640375: D19286.id46152.diff
Jul 11 2025, 6:31 PM
Unknown Object (File)
Jun 27 2025, 10:21 PM
Subscribers
None

Details

Summary

Depends on D19285. Ref T13110. When you update an "Abandoned + But, Never Promoted" revision or (in the future) a "Changes Planned + But, Never Promoted" revision, return it to the "Draft" state rather than promoting it.

Test Plan

Updated an "Abandoned + Draft" revision, saw it return to "Draft".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable