Page MenuHomePhabricator

Explicitly condition Differential draft promotion on only "impactful" builds
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 11:11 PM
Unknown Object (File)
Wed, Nov 13, 12:33 AM
Unknown Object (File)
Tue, Nov 12, 11:55 PM
Unknown Object (File)
Sun, Nov 10, 2:04 AM
Unknown Object (File)
Oct 23 2024, 4:11 AM
Unknown Object (File)
Oct 18 2024, 5:19 PM
Unknown Object (File)
Oct 12 2024, 1:17 AM
Unknown Object (File)
Oct 9 2024, 9:17 AM
Subscribers
None

Details

Summary

Depends on D19281. This increases consistency between build timeline publishing and revision draft promotion.

There's no real behavioral change here (switching how publishing worked already changed the beahvior) but this sends more callsites down the same code paths.

Since the builds we're looking at include completed builds, change the term "active" to "impactful". This describes the same set of builds, but hopefully describes them more accurately.

Test Plan

Created a local revision, saw it plausibly interact with draft status and promote. There are a lot of moving parts here and some stuff may well have slipped through.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable