Page MenuHomePhabricator

Partially decouple revision broadcasting from revision draft state
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:23 PM.
Tags
None
Referenced Files
F18713712: D19284.diff
Mon, Sep 29, 6:45 AM
F18625506: D19284.id46166.diff
Mon, Sep 15, 10:57 PM
F18614021: D19284.id46150.diff
Sun, Sep 14, 11:55 AM
F18509498: D19284.id.diff
Sep 5 2025, 3:26 AM
F18502546: D19284.diff
Sep 4 2025, 10:30 PM
F18167194: D19284.id46166.diff
Aug 15 2025, 11:31 AM
F18086879: D19284.id46150.diff
Aug 6 2025, 12:55 AM
F18053428: D19284.id.diff
Aug 4 2025, 4:59 AM
Subscribers
None

Details

Summary

Depends on D19283. Ref T13110. To enable "Changes Planned + But, Still A Draft" and "Abandoned + But, Never Promoted From Draft" states, decouple the "broadcast" flag from the "draft" state.

Broadcast behavior is now based only on the shouldBroadcast flag, and revisions in any state may have this flag.

Revisions gain this flag when created as a non-draft, or when they leave the draft state for the first time.

There are probably still some ways you can get the wrong result here -- maybe abandon + update -- but those can be cleaned up as they arise.

Test Plan

Kinda poked it a bit but I'll vet this more heavily at the end of this sequence.

Diff Detail

Repository
rP Phabricator
Branch
bengine7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19971
Build 27077: Run Core Tests
Build 27076: arc lint + arc unit