Page MenuHomePhabricator

Partially decouple revision broadcasting from revision draft state
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:23 PM.
Tags
None
Referenced Files
F13273501: D19284.diff
Fri, May 31, 2:00 AM
F13247651: D19284.diff
Thu, May 23, 9:19 PM
F13239243: D19284.id.diff
Wed, May 22, 1:22 AM
F13233342: D19284.diff
Tue, May 21, 2:13 AM
F13228899: D19284.diff
Mon, May 20, 1:07 PM
F13226802: D19284.id46166.diff
Sun, May 19, 11:30 PM
F13201838: D19284.id.diff
Tue, May 14, 5:20 PM
F13193840: D19284.diff
Sun, May 12, 6:27 PM
Subscribers
None

Details

Summary

Depends on D19283. Ref T13110. To enable "Changes Planned + But, Still A Draft" and "Abandoned + But, Never Promoted From Draft" states, decouple the "broadcast" flag from the "draft" state.

Broadcast behavior is now based only on the shouldBroadcast flag, and revisions in any state may have this flag.

Revisions gain this flag when created as a non-draft, or when they leave the draft state for the first time.

There are probably still some ways you can get the wrong result here -- maybe abandon + update -- but those can be cleaned up as they arise.

Test Plan

Kinda poked it a bit but I'll vet this more heavily at the end of this sequence.

Diff Detail

Repository
rP Phabricator
Branch
bengine7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19971
Build 27077: Run Core Tests
Build 27076: arc lint + arc unit