Page MenuHomePhabricator

Explicitly condition Differential draft promotion on only "impactful" builds
ClosedPublic

Authored by epriestley on Apr 3 2018, 3:06 PM.
Tags
None
Referenced Files
F14045064: D19282.id46164.diff
Wed, Nov 13, 12:33 AM
F14045004: D19282.id46164.diff
Tue, Nov 12, 11:55 PM
F14034754: D19282.diff
Sun, Nov 10, 2:04 AM
F13994143: D19282.id46164.diff
Wed, Oct 23, 4:11 AM
F13977138: D19282.diff
Fri, Oct 18, 5:19 PM
Unknown Object (File)
Oct 12 2024, 1:17 AM
Unknown Object (File)
Oct 9 2024, 9:17 AM
Unknown Object (File)
Oct 9 2024, 9:17 AM
Subscribers
None

Details

Summary

Depends on D19281. This increases consistency between build timeline publishing and revision draft promotion.

There's no real behavioral change here (switching how publishing worked already changed the beahvior) but this sends more callsites down the same code paths.

Since the builds we're looking at include completed builds, change the term "active" to "impactful". This describes the same set of builds, but hopefully describes them more accurately.

Test Plan

Created a local revision, saw it plausibly interact with draft status and promote. There are a lot of moving parts here and some stuff may well have slipped through.

Diff Detail

Repository
rP Phabricator
Branch
bengine5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/editor/DifferentialTransactionEditor.php:1580XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19969
Build 27073: Run Core Tests
Build 27072: arc lint + arc unit