Page MenuHomePhabricator

Move structural build publishing logic to BuildEngine, provide "bin/harbormaster publish"
ClosedPublic

Authored by epriestley on Apr 3 2018, 1:05 PM.
Tags
None
Referenced Files
F15455094: D19279.id46161.diff
Sat, Mar 29, 10:10 PM
F15455093: D19279.id46145.diff
Sat, Mar 29, 10:09 PM
F15455092: D19279.id.diff
Sat, Mar 29, 10:09 PM
F15453577: D19279.id46145.diff
Sat, Mar 29, 12:46 PM
F15448144: D19279.diff
Fri, Mar 28, 3:19 AM
F15445383: D19279.id.diff
Thu, Mar 27, 1:38 PM
F15441067: D19279.diff
Wed, Mar 26, 4:13 PM
F15430982: D19279.id46161.diff
Mon, Mar 24, 9:57 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19278. Ref T13110. This moves most of the structural logic for publishing builds to BuildableEngine and provides a bin/harbormaster publish to make publishing easy to retry/debug.

This intentionally removes the bit which actually does anything when builds publish. Followup changes will implement application-specific versions of the publishing logic in Differential and Diffusion.

Test Plan

Ran bin/harbormaster publish Bxxx, saw it do nothing (but not crash).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 3 2018, 1:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 5:58 PM
This revision was automatically updated to reflect the committed changes.