Page MenuHomePhabricator

Move structural build publishing logic to BuildEngine, provide "bin/harbormaster publish"
ClosedPublic

Authored by epriestley on Apr 3 2018, 1:05 PM.
Tags
None
Referenced Files
F20107401: D19279.diff
Tue, Jun 2, 2:03 PM
Unknown Object (File)
Jan 5 2026, 12:09 PM
Unknown Object (File)
Jan 4 2026, 2:36 PM
Unknown Object (File)
Nov 30 2025, 12:01 PM
Unknown Object (File)
Nov 24 2025, 11:57 PM
Unknown Object (File)
Oct 25 2025, 1:49 PM
Unknown Object (File)
Oct 15 2025, 2:13 PM
Unknown Object (File)
Oct 7 2025, 11:53 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19278. Ref T13110. This moves most of the structural logic for publishing builds to BuildableEngine and provides a bin/harbormaster publish to make publishing easy to retry/debug.

This intentionally removes the bit which actually does anything when builds publish. Followup changes will implement application-specific versions of the publishing logic in Differential and Diffusion.

Test Plan

Ran bin/harbormaster publish Bxxx, saw it do nothing (but not crash).

Diff Detail

Repository
rP Phabricator
Branch
bengine2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19966
Build 27067: Run Core Tests
Build 27066: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 3 2018, 1:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 5:58 PM
This revision was automatically updated to reflect the committed changes.