Page MenuHomePhabricator

Change arcanist error output
AbandonedPublic

Authored by joshuaspence on May 15 2015, 2:23 AM.
Tags
None
Referenced Files
F14024182: D12851.diff
Thu, Nov 7, 6:52 AM
F13976728: D12851.diff
Oct 18 2024, 3:26 PM
F13976687: D12851.id.diff
Oct 18 2024, 3:18 PM
F13976678: D12851.id30920.diff
Oct 18 2024, 3:17 PM
F13976667: D12851.id31554.diff
Oct 18 2024, 3:15 PM
F13973981: D12851.id31554.diff
Oct 18 2024, 3:32 AM
F13960820: D12851.id30920.diff
Oct 15 2024, 1:41 AM
Unknown Object (File)
Oct 13 2024, 2:58 PM
Subscribers

Details

Summary

Ref T8156. Change the error output from arcanist to respect the output from custom __toString() methods.

Test Plan

Created a custom Exception class which implemented a __toString() method. Saw exception messages as expected.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6381
Build 6403: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Change arcanist error output.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited the test plan for this revision. (Show Details)

Is this still relevant? What's the remaining use case for implementing a custom __toString() instead of having getMessage() return the desired value? (It looks like none of our exceptions implement __toString().)