Paths

Table of Contentst

Differential D12851

Change arcanist error output
AbandonedPublic
Actions

Authored by joshuaspence on May 15 2015, 2:23 AM.

Tags

None

Referenced Files

	F15451127: D12851.id.diff
	Fri, Mar 28, 8:17 PM

	F15448933: D12851.id31554.diff
	Fri, Mar 28, 7:45 AM

	F15443797: D12851.diff
	Thu, Mar 27, 6:15 AM

	F15422954: D12851.id31554.diff
	Sat, Mar 22, 11:39 AM

	F15421176: D12851.diff
	Fri, Mar 21, 9:27 PM

	F15416641: D12851.diff
	Thu, Mar 20, 12:42 PM

	F15412457: D12851.id31554.diff
	Wed, Mar 19, 1:06 PM

	F15396861: D12851.id31554.diff
	Sun, Mar 16, 4:41 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8156: Linter failures don't provide relevant stacktraces

Summary

Ref T8156. Change the error output from arcanist to respect the output from custom __toString() methods.

Test Plan

Created a custom Exception class which implemented a __toString() method. Saw exception messages as expected.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6381
Build 6403: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30920.May 15 2015, 2:23 AM

joshuaspence retitled this revision from to Change arcanist error output.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8156: Linter failures don't provide relevant stacktraces.

joshuaspence added a parent revision: D12796: Provide stacktraces for aggregate exceptions.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 2:23 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence updated this object.May 15 2015, 6:25 AM

joshuaspence edited edge metadata.

epriestley mentioned this in D13007: Automatically compile aggregate stack traces for complex exceptions.May 25 2015, 3:31 PM

joshuaspence added a child revision: D12899: Remove remaining arcanist project code.May 25 2015, 10:18 PM

joshuaspence updated this object.May 26 2015, 11:55 AM

joshuaspence removed a parent revision: D12796: Provide stacktraces for aggregate exceptions.

epriestley mentioned this in rPHUc2cd90ee7aec: Automatically compile aggregate stack traces for complex exceptions.May 26 2015, 1:06 PM

joshuaspence removed a child revision: D12899: Remove remaining arcanist project code.May 26 2015, 1:24 PM

joshuaspence updated this object.May 31 2015, 2:37 AM

Rebase

joshuaspence updated this object.May 31 2015, 2:44 AM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence mentioned this in D13079: Improve error output with aggregate exceptions.May 31 2015, 2:44 AM

Is this still relevant? What's the remaining use case for implementing a custom __toString() instead of having getMessage() return the desired value? (It looks like none of our exceptions implement __toString().)

Yeah, I guess not.

Revision Contents
Changeset List

Path

Size

scripts/

3 lines

Diff 31554

scripts/arcanist.php

Loading...