Allow "+" to remain unescaped by csprintf('%R', ...)

Authored by epriestley on May 10 2016, 11:56 PM.

Description

Allow "+" to remain unescaped by csprintf('%R', ...)

Summary:
Ref T10923. Currently, when we %R ("readable") escape SVN SSH URIs (svn+ssh://...), they get quoted because they contain a +.

However, they don't need to be quoted, since + is not a special character in the shell.

Test Plan:

  • Added and ran test cases.
  • Viewed SVN in Diffusion, saw unquoted checkout URI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10923

Differential Revision: https://secure.phabricator.com/D15882

Details

Committed
epriestleyMay 11 2016, 1:39 PM
Pushed
epriestleyMay 11 2016, 1:39 PM
Reviewer
chad
Differential Revision
D15882: Allow "+" to remain unescaped by csprintf('%R', ...)
Parents
rPHU180f0999d094: Fix LiskMigrationIterator scaling in O(n^2)
Branches
Unknown
Tags
Unknown
Tasks
T10923: Diffusion API/URI Errata
Build Status
Buildable 12137
Build 15309: Run Core Tests