Page MenuHomePhabricator

Allow "+" to remain unescaped by csprintf('%R', ...)
ClosedPublic

Authored by epriestley on May 11 2016, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 12:49 AM
Unknown Object (File)
Sat, Nov 16, 1:10 PM
Unknown Object (File)
Tue, Nov 12, 11:34 AM
Unknown Object (File)
Mon, Nov 11, 2:44 AM
Unknown Object (File)
Fri, Nov 8, 11:34 AM
Unknown Object (File)
Wed, Oct 30, 11:15 PM
Unknown Object (File)
Oct 19 2024, 11:34 PM
Unknown Object (File)
Oct 18 2024, 1:40 PM
Subscribers
None

Details

Summary

Ref T10923. Currently, when we %R ("readable") escape SVN SSH URIs (svn+ssh://...), they get quoted because they contain a +.

However, they don't need to be quoted, since + is not a special character in the shell.

Test Plan
  • Added and ran test cases.
  • Viewed SVN in Diffusion, saw unquoted checkout URI.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow "+" to remain unescaped by csprintf('%R', ...).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 2:57 AM
This revision was automatically updated to reflect the committed changes.