Page MenuHomePhabricator

Allow "+" to remain unescaped by csprintf('%R', ...)
ClosedPublic

Authored by epriestley on May 11 2016, 12:01 AM.
Tags
None
Referenced Files
F14009728: D15882.id38250.diff
Wed, Oct 30, 11:15 PM
F13982478: D15882.id.diff
Sat, Oct 19, 11:34 PM
F13976306: D15882.diff
Fri, Oct 18, 1:40 PM
F13967675: D15882.id38262.diff
Wed, Oct 16, 3:10 PM
Unknown Object (File)
Sep 21 2024, 8:45 PM
Unknown Object (File)
Sep 20 2024, 5:59 PM
Unknown Object (File)
Sep 5 2024, 8:16 PM
Unknown Object (File)
Sep 5 2024, 8:16 PM
Subscribers
None

Details

Summary

Ref T10923. Currently, when we %R ("readable") escape SVN SSH URIs (svn+ssh://...), they get quoted because they contain a +.

However, they don't need to be quoted, since + is not a special character in the shell.

Test Plan
  • Added and ran test cases.
  • Viewed SVN in Diffusion, saw unquoted checkout URI.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow "+" to remain unescaped by csprintf('%R', ...).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 2:57 AM
This revision was automatically updated to reflect the committed changes.