HomePhabricator
Diffusion libphutil 6fe33623cda6

Make the query compiler emit intermediate tokens
6fe33623cda6
Actions

Description

Make the query compiler emit intermediate tokens

Summary:
Ref T12137. Ref T12003. Ref T2632. Ref T7860. In all these tasks, we want to examine or interact with the query after it is parsed, but before it is compiled.

Make the compiler emit an intermediate parsed representation so we can do that.

(The next change fixes Phabricator for this new API.)

Test Plan: Ran unit tests, see also next change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12137, T12003, T7860, T2632

Differential Revision: https://secure.phabricator.com/D17669

Details

Provenance
epriestleyAuthored on Apr 12 2017, 10:27 PM
epriestleyPushed on Apr 13 2017, 2:06 AM
Reviewer
chad
Differential Revision
D17669: Make the query compiler emit intermediate tokens
Parents
rPHUfb9e0642c4ea: Reject ambiguous URIs with unescaped "#" or "?" in username/password parts
Branches
Unknown
Tags
Unknown
Tasks
T12003: Explain to users how fulltext queries are parsed and executed
T7860: When users search for "#x y", treat "#x" as a project hashtag
T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it
T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token
Build Status
Buildable 16432
Build 21866: Run Core Tests

Event Timeline

epriestley committed rPHU6fe33623cda6: Make the query compiler emit intermediate tokens (authored by epriestley).Apr 13 2017, 2:06 AM
epriestley added a task: T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
epriestley added a task: T12003: Explain to users how fulltext queries are parsed and executed.
epriestley added a task: T7860: When users search for "#x y", treat "#x" as a project hashtag.
epriestley added a task: T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.
Harbormaster completed building B16432: rPHU6fe33623cda6: Make the query compiler emit intermediate tokens.Apr 13 2017, 2:06 AM
epriestley mentioned this in 2017 Week 15 (Mid April).Apr 14 2017, 8:37 PM
atul.agrawal9911 mentioned this in T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd`.Apr 17 2017, 1:09 PM
atul.agrawal9911 mentioned this in T12579: ./bin/mail show-outbound command should type check <id>.Apr 18 2017, 5:38 AM
atul.agrawal9911 mentioned this in T12585: Unable to create differential .Apr 18 2017, 12:22 PM
kevinchea mentioned this in T12614: Add file transform unit tests.Apr 21 2017, 7:05 AM
epriestley mentioned this in 2017 Week 16 (Late April).Apr 21 2017, 11:56 PM
nevogd mentioned this in T12622: Unhandled Exception ("RuntimeException") when accessing conpherence.Apr 22 2017, 2:10 PM
CodeMouse92 mentioned this in T12488: Old Calendar events didn't get a utcInstanceEpoch populated, causing fatals on export.Apr 25 2017, 8:12 PM

Changes (4)

PathSize
src/
search/
__tests__/

rPHU6fe33623cda6

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/search/PhutilSearchQueryCompiler.php

Loading...
View Options

src/search/PhutilSearchQueryToken.php

Loading...
View Options

src/search/__tests__/PhutilSearchQueryCompilerTestCase.php

Loading...
Phabricator ยท Built by Phacility