HomePhabricator

Make callsigns optional in arcanist

Description

Make callsigns optional in arcanist

Summary:
Remove couple of references to callsigns:

  • arc which now prints repository name
  • getShouldAmend() can now use new format of commit name

a quick git-grep looks like the remaining references are all about repository.callsign config.

Ref T4245

Test Plan:

  • arc which on a repository with no callsign
  • trigger requireCleanWorkingCopy(), see both "Do you want to amend this change" and "Do you want to create a new commit" prompts.
  • fire this diff with new code.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D15472

Details

Provenance
aviveyAuthored on Mar 15 2016, 3:58 AM
industryPushed on Mar 15 2016, 3:58 AM
Reviewer
Blessed Reviewers
Differential Revision
D15472: Make callsigns optional in arcanist
Parents
rARCccbaee585e1a: When `arc` pushes to the staging area, tell Phabricator what we did
Branches
Unknown
Tags
Unknown
Tasks
T4245: Make repository URIs slightly prettier
Build Status
Buildable 11157
Build 13833: Run Core Tests

Event Timeline