Page MenuHomePhabricator
Create Task
Maniphest T10657

Descriptions not escaped for Amazon Web Services Settings
Closed, InvalidPublic
Actions

Description

Nothing major. The descriptions for the Amazon Web Services Settings include S3 alot, which if you have a Space with the ID of 3, is replaced with an embedded link to that space.

Reproduction Steps
Create a space with an ID of 3.
Go to Config → Amazon Web Services
Note embedded link to Space 3.

Version Information
phabricator e3f89279f9126e09f23b1d9d7d0488751830aa83 (Tue, Mar 22)
arcanist 3d7ac867f53892b8210339bbb0c5fd91e0e36d78 (Mon, Mar 14)
phutil b4f38af384807b7dcd1e3d1a96e9e9069e4d6964 (Fri, Mar 18)

Related Objects

Event Timeline

kymera.travis renamed this task from Descriptions not escaped for Amazon to Descriptions not escaped for Amazon Web Services Settings.Mar 23 2016, 10:03 PM
kymera.travis created this task.
kymera.travis updated the task description. (Show Details)
kymera.travis updated the task description. (Show Details)Mar 23 2016, 10:07 PM
chad closed this task as Invalid.Mar 23 2016, 10:11 PM
chad added a subscriber: chad.

We set remarkup.ignored-object-names to /^(?:(Q|V)\d|S3)$/ under Config → Core

chad added a comment.Mar 23 2016, 10:18 PM

Also related is T3278. There is no current means of having different flavors of Remarkup, it's all or nothing. So a "no object" Remarkup would similar to a "object only" Remarkup, and so on. For now installs just should either use a regex like above or the admins should tough it out until T3278.

kymera.travis added a comment.Mar 23 2016, 10:24 PM

This doesn't appear to be the default value on our install, unless you just meant its what been set here?

Realistically speaking this problem shouldn't affect anyone, its an incredibly minor bug in the configuration UI.

chad added a comment.Mar 23 2016, 10:25 PM

It's not the default value, I'm sharing what ours is set to in case you want to use it.

chad added a comment.Mar 23 2016, 10:28 PM

Sorry, if that wasn't clear. "We" means just this install, not Phabricator by default.

kymera.travis added a comment.Mar 23 2016, 11:19 PM

Thanks for sharing but I don't think that'll be necessary. The only place this will likely be an issue is on the config screen (and there its mostly moot).

Phabricator · Built by Phacility