Page MenuHomePhabricator

XHProfProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Jan 30 2019

epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Success! D20046 worked to fix the "profiler not sticking across form posts" issue on secure. 馃悎

Jan 30 2019, 7:56 PMXHProf, Ops, Phacility

Jan 28 2019

epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: D20046: Read "$_POST" before hooking the profiler, and remove "aphront.default-application-configuration-class".
Jan 28 2019, 7:09 PMXHProf, Ops, Phacility
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Yeah, I think the issue is:

Jan 28 2019, 6:41 PMXHProf, Ops, Phacility
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

The "keep the profiler on across form submissions" code isn't working on secure.phabricator.com, even though it works locally and __profile__=page appears on the "Request" tab.

Jan 28 2019, 4:58 PMXHProf, Ops, Phacility

Sep 27 2018

epriestley moved T9254: Make --xprofile upload to XHProf from Backlog to Upstream on the Arcanist board.
Sep 27 2018, 3:17 PMXHProf, Arcanist

Nov 29 2017

epriestley added a comment to T9805: XHProf will not build on PHP7.

(I'm also open to improvements to the XHProf UI in Phabricator if you plan to use that to store and review profiles. Many obvious features like tagging and API access which would make it more usable for handling profiles of projects other than Phabricator itself are likely very easy to implement. But I'm not sure there's tons of room for real integrations, even if you used everything else in Phabricator, and you may imagine tooling which can't realistically exist in the scope of Phabricator.)

Nov 29 2017, 9:05 PMXHProf
epriestley added a comment to T9805: XHProf will not build on PHP7.

For general context:

Nov 29 2017, 8:58 PMXHProf
20after4 updated subscribers of T9805: XHProf will not build on PHP7.
Nov 29 2017, 6:50 PMXHProf

Nov 28 2017

epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: Restricted Differential Revision.
Nov 28 2017, 3:51 PMXHProf, Ops, Phacility

Apr 4 2017

epriestley removed a project from T7954: Make it easier to upload XHProf profiles: Files.

(This isn't really very closely related to the Files application anymore, just cleaning up that board a little.)

Apr 4 2017, 1:01 PMInfrastructure, XHProf

Feb 26 2017

epriestley added a comment to T9805: XHProf will not build on PHP7.

I have a build of this that technically works now (produces profiles, passes tests, does not segfault when gently poked). It's still extremely really rough so I don't know when I'll clean it up enough to push upstream.

Feb 26 2017, 11:45 PMXHProf

Feb 25 2017

epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Total cost is about 1.6s. Of this:

Feb 25 2017, 4:09 PMXHProf, Ops, Phacility
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

This is still a little bit of a pain but far more reasonable now, here's an actual profile:

Feb 25 2017, 4:03 PMXHProf, Ops, Phacility

Feb 23 2017

epriestley added a comment to T7954: Make it easier to upload XHProf profiles.

I didn't "ref" it here, but D17401 sort of technically did this. I'd like to clean it up a bit more before calling this resolved, though -- particularly, this is basically a secret that only I know about.

Feb 23 2017, 7:34 PMInfrastructure, XHProf
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: D17401: Allow XHProf profiles to be drag-and-dropped to upload them.
Feb 23 2017, 6:41 PMXHProf, Ops, Phacility
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: D17400: Use ApplicationSearch in XHProf.
Feb 23 2017, 5:59 PMXHProf, Ops, Phacility
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: D17399: When the profiler is active, keep it active if the user submits forms.
Feb 23 2017, 5:31 PMXHProf, Ops, Phacility

Feb 22 2017

epriestley added a subtask for T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: T7954: Make it easier to upload XHProf profiles.
Feb 22 2017, 12:16 PMXHProf, Ops, Phacility
epriestley added a parent task for T7954: Make it easier to upload XHProf profiles: T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.
Feb 22 2017, 12:16 PMInfrastructure, XHProf

Feb 20 2017

epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Some possible approaches here:

Feb 20 2017, 4:34 PMXHProf, Ops, Phacility
epriestley updated the task description for T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.
Feb 20 2017, 4:33 PMXHProf, Ops, Phacility
epriestley created T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.
Feb 20 2017, 4:19 PMXHProf, Ops, Phacility
epriestley added a parent task for T9805: XHProf will not build on PHP7: T12101: Phabricator PHP 7 Compatibility.
Feb 20 2017, 4:16 PMXHProf
epriestley moved T7954: Make it easier to upload XHProf profiles from Backlog to vNext on the XHProf board.
Feb 20 2017, 4:13 PMInfrastructure, XHProf

Dec 3 2016

legoktm added a comment to T9805: XHProf will not build on PHP7.

For reference, xhprof will not be included in Debian Stretch due to lack of PHP7 support: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=846138

Dec 3 2016, 11:30 PMXHProf

Apr 1 2016

michaeljs1990 added a comment to T9805: XHProf will not build on PHP7.

keep in mind that that was successfully compiled by removing lots of code https://github.com/RustJason/xhprof/commit/6c473e39fa93fb7f0acc3fae73f626e5c66dff1a and i'm not completely sure of the implications of the changes.

Apr 1 2016, 8:38 PMXHProf

Feb 15 2016

kleijnweb added a comment to T9805: XHProf will not build on PHP7.

For my (and others') understanding, the discussion is limited to how to make the needed changes BC, otherwise https://github.com/RustJason/xhprof/tree/php7 would be fine? If so, might I suggest a new major version?

Feb 15 2016, 6:13 AMXHProf

Nov 19 2015

Mnkras added a comment to T9805: XHProf will not build on PHP7.

I don't think that is going to work here are some things I pulled from the extension migration page (unless we ifdef large blocks of code):

zval

  • PHPNG doesn't require any involvement of pointers to pointers to zval. Most occurrences of zval** variables and parameters have to be changed into zval*. The corresponding Z_*_PP() macros that work with such variables should be changed into Z_*_P().
  • In many places PHPNG work with zval directly (eliminating need for allocation and deallocation). In these cases corresponding zval* variable should be converted into plain zval, macros that use this variable from Z_*P() into Z_*() and corresponding creation macros from ZVAL_*(var, 鈥) into ZVAL_*(&var, 鈥). Be always careful about passing addresses of zval and & operator. PHPNG almost never require passing address of zval*. In some places & operator should be removed.
  • zval allocation macros ALLOC_ZVAL, ALLOC_INIT_ZVAL, MAKE_STD_ZVAL are removed. In most cases their usage indicate that zval* need to be changed into plain zval. Macro INIT_PZVAL is removed as well and its usages in most cases should be just removed.
Nov 19 2015, 2:39 AMXHProf

Nov 18 2015

epriestley added a comment to T9805: XHProf will not build on PHP7.
  • If the changes are relatively minor, add a bunch more #ifdefs? We already have some of this to deal with prior API changes, and I believe this approach is historically a standard one across other extensions.
    • If the changes are substantial, maybe we need to get more creative.
Nov 18 2015, 4:14 PMXHProf
Mnkras updated subscribers of T9805: XHProf will not build on PHP7.

@epriestley, due to the fact that the Zend APIs for PHP7+ are different than those in PHP5* how should changes to XHProf be submitted so we don't break stuff?

Nov 18 2015, 3:29 PMXHProf

Nov 17 2015

richardvanvelzen added a comment to T9805: XHProf will not build on PHP7.

https://wiki.php.net/phpng-upgrading should contain a lot of relevant information.

Nov 17 2015, 8:48 PMXHProf
joshuaspence renamed T9805: XHProf will not build on PHP7 from XHPAST will not build on PHP7 to XHProf will not build on PHP7.
Nov 17 2015, 7:07 AMXHProf
Mnkras added a parent task for T9805: XHProf will not build on PHP7: T9640: Make Phabricator compatible with PHP7.
Nov 17 2015, 4:49 AMXHProf
Mnkras created T9805: XHProf will not build on PHP7.
Nov 17 2015, 4:37 AMXHProf

Aug 25 2015

epriestley added a comment to T9254: Make --xprofile upload to XHProf.

--upload-xprofile is definitely more useful overall than --xprofile <file> since 99% of the time I've also done some approximation of that upload dance, it just feels a little weird for some stuff to take --xprofile <file> and some stuff to take --xprofile which takes no argument and means something completely different.

Aug 25 2015, 4:17 AMXHProf, Arcanist

Aug 24 2015

joshuaspence added a comment to T9254: Make --xprofile upload to XHProf.

It seems sort-of-nice-to-have to have the raw version, maybe.

Aug 24 2015, 9:34 PMXHProf, Arcanist
joshuaspence added a comment to T9254: Make --xprofile upload to XHProf.

Not sure if it would be desirable but perhaps Arcanist would override libphutil's --xprofile and wrap around it to provide the suggested functionality? This is probably too magical. arc --upload-xprofile seems reasonable.

Aug 24 2015, 9:32 PMXHProf, Arcanist
epriestley added a comment to T9254: Make --xprofile upload to XHProf.

I think --xprofile is provided by libphutil but it doesn't know about Phabricator. It seems sort-of-nice-to-have to have the raw version, maybe. Not sure how easy it is to add --upload-xprofile to arc.

Aug 24 2015, 9:30 PMXHProf, Arcanist
joshuaspence updated the task description for T9254: Make --xprofile upload to XHProf.
Aug 24 2015, 8:57 PMXHProf, Arcanist
joshuaspence updated the task description for T9254: Make --xprofile upload to XHProf.
Aug 24 2015, 8:57 PMXHProf, Arcanist
joshuaspence created T9254: Make --xprofile upload to XHProf.
Aug 24 2015, 8:56 PMXHProf, Arcanist

Aug 6 2015

joshuaspence added a member for XHProf: joshuaspence.
Aug 6 2015, 9:08 AM

May 7 2015

epriestley triaged T7954: Make it easier to upload XHProf profiles as Wishlist priority.
May 7 2015, 1:42 PMInfrastructure, XHProf

Apr 26 2015

joshuaspence created T7954: Make it easier to upload XHProf profiles.
Apr 26 2015, 10:12 PMInfrastructure, XHProf

Mar 13 2015

chad closed T7300: XHProf application is not optimized for mobile as Resolved.

Should be resolved, probably.

Mar 13 2015, 6:41 PMMobile, XHProf

Mar 5 2015

chad added a revision to T7300: XHProf application is not optimized for mobile: D11980: Set device true on all XHProf pages.
Mar 5 2015, 4:47 PMMobile, XHProf
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

Definitely desirable, although some of them (releeph, oauth server, arcanist project edit) might be tricky to test.

Mar 5 2015, 4:20 PMMobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

There is a manageable number of buildStandardPage callsites, might be easy to remove if there is only 1-2 missing features.

Mar 5 2015, 4:12 PMMobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

Typically I'd just switch this over to buildApplicationPage and call it a day, but I don't think that works with frame.

Mar 5 2015, 4:11 PMMobile, XHProf
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

I think we can put the frame logic in buildApplicationPage(), and then switch to it. I can tackle that if you aren't sure how to not break stuff.

Mar 5 2015, 4:10 PMMobile, XHProf