Page MenuHomePhabricator
Differential D11980

Set device true on all XHProf pages
ClosedPublic
Actions

Authored by chad on Mar 5 2015, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:09 AM
Unknown Object (File)
Sun, Nov 3, 1:57 PM
Unknown Object (File)
Fri, Oct 25, 5:11 PM
Unknown Object (File)
Oct 21 2024, 12:04 AM
Unknown Object (File)
Oct 21 2024, 12:04 AM
Unknown Object (File)
Oct 21 2024, 12:04 AM
Unknown Object (File)
Oct 20 2024, 11:58 PM
Unknown Object (File)
Oct 19 2024, 12:16 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7300: XHProf application is not optimized for mobile
Commits
Restricted Diffusion Commit
rPf9dc4ef6d80b: Set device true on all XHProf pages
Summary

Pass this as true when building XHProf pages

Test Plan

Verify setDeviceReady exists in class PhabricatorBarePageView

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28832.Mar 5 2015, 4:17 PM
chad retitled this revision from to Set device true on all XHProf pages.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 5 2015, 4:17 PM
epriestley accepted this revision.Mar 5 2015, 4:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2015, 4:36 PM
Closed by commit rPf9dc4ef6d80b: Set device true on all XHProf pages (authored by chad, committed by chad). · Explain WhyMar 5 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T7300: XHProf application is not optimized for mobile.Mar 5 2015, 4:47 PM

Revision Contents
Changeset List

PathSize
src/
applications/
xhprof/
controller/
1 line

Diff 28835

View Options

src/applications/xhprof/controller/PhabricatorXHProfController.php

Loading...
Phabricator · Built by Phacility