Differential D11980

Set device true on all XHProf pages
ClosedPublic
Actions

Authored by chad on Mar 5 2015, 4:17 PM.

Tags

None

Referenced Files

	F15521351: D11980.id.diff
	Sun, Apr 20, 1:20 PM

	F15517405: D11980.diff
	Sat, Apr 19, 2:48 AM

	F15464947: D11980.id28832.diff
	Wed, Apr 2, 1:10 PM

	F15389547: D11980.id28832.diff
	Mar 15 2025, 5:23 AM

	F15382527: D11980.id28835.diff
	Mar 14 2025, 12:50 PM

	F15360729: D11980.id28832.diff
	Mar 11 2025, 9:48 AM

	Unknown Object (File)
	Feb 17 2025, 11:23 AM

	Unknown Object (File)
	Feb 8 2025, 2:52 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T7300: XHProf application is not optimized for mobile

Commits

Restricted Diffusion Commit
rPf9dc4ef6d80b: Set device true on all XHProf pages

Summary

Pass this as true when building XHProf pages

Test Plan

Verify setDeviceReady exists in class PhabricatorBarePageView

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28832.Mar 5 2015, 4:17 PM

chad retitled this revision from to Set device true on all XHProf pages.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 5 2015, 4:17 PM

epriestley accepted this revision.Mar 5 2015, 4:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2015, 4:36 PM

Closed by commit rPf9dc4ef6d80b: Set device true on all XHProf pages (authored by chad, committed by chad). · Explain WhyMar 5 2015, 4:45 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T7300: XHProf application is not optimized for mobile.Mar 5 2015, 4:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

xhprof/

controller/

PhabricatorXHProfController.php

1 line

Diff 28835

View Options

src/applications/xhprof/controller/PhabricatorXHProfController.php

Set device true on all XHProf pagesClosedPublicActions