@joshuaspence as the blocking reviewer can you take another look? It seems like @michaeljs1990 has addressed all your requests.

@yangsu your https://github.com/coursera/arcanist/blob/master/src/lint/linter/ArcanistESLintLinter.php works well. Would you be willing to commandeer this and merge the functionality?

@avivey thanks for bringing this up to snuff for merging upstream!

In T9456#141036, @epriestley wrote:

I'm still just working through this with CircleCI support. No real headway yet, turnaround has been ~24+ hours every time so we're still just discussing the problem.

We don't have any integration yet of Phabricator with CircleCI. We do have Github + CircleCI which runs CI for every push to every branch. (E.g. https://circleci.com/gh/remind101/empire)

In D9858#146223, @eMxyzptlk wrote:

@turadg can you please update this revision on top of master? I have already done so myself, I can Commandeer the revision and push my version if you'd like to.

@epriestley what would you like to see in order to Accept this? It will help people using JIRA to adopt Phabricator Differential in their orgs. It has in mine.

• conform to most linting

• fix bug after testing in production

• add configuration options

revise per @epriestley feedback

I would like to pursue getting this into master. To keep it simple, would it be easier to implement the comment/link options in /config/group/differential/ or a new "Integration with JIRA" config option group?

@a1fred0, your wish is in T5422

Since updating to this revision, I get this error:

$ arc linters
Exception
Failed to parse '.../site/.git/arc/config' as JSON.
Parse error on line 1 at column 0: Expected one of: 'STRING', 'NUMBER', 'NULL', 'TRUE', 'FALSE', '{', '['
(Run with --trace for a full exception trace.)