Page MenuHomePhabricator

Remove --background flag to prevent `arc` from hanging
ClosedPublic

Authored by epriestley on Aug 8 2014, 8:34 PM.

Details

Summary

Ref T4281. A long time ago, we added a --background flag to let arc lint and arc unit run while you're typing a commit message, in some situations.

This code is only moderately beneficial and is way too complicated. Particularly, it has a long history of causing hangs (T4281, T2463), doesn't work on Windows, and is impossible to debug.

It's also running into a serious PHP bug with EAGAIN/EPIPE being indistinguishable that I haven't been able to find a reasonable workaround for in ~3-4 hours of trying.

All the pathways forward that I can see make this already-complex system more complex.

The major reason that this stuff is so complex is that the subprocess may need to prompt the user (notably, to apply patches from lint).

Instead, I'm going to simplify how arc diff interacts with arc lint and arc unit, so we can just fire-and-forget a background process, let it do as much work as it can without needing user input, and then pick up wherever it left off. This will be slightly less cool/magical, but it won't hang bizarrely and I will be able to debug it.

For now, simply remove the --background flag and behavior so arc works for everyone.

Test Plan

Ran arc diff to create this diff.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24539.Aug 8 2014, 8:34 PM
epriestley retitled this revision from to Remove --background flag to prevent `arc` from hanging.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
vm awarded a token.Aug 8 2014, 9:57 PM
btrahan accepted this revision.Aug 8 2014, 10:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 8 2014, 10:16 PM
epriestley closed this revision.Aug 8 2014, 11:09 PM
epriestley updated this revision to Diff 24546.

Closed by commit rARC54bea946c120 (authored by @epriestley).