Page MenuHomePhabricator

sowedance (Peng Li)
UserEmail Not Verified

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2013, 12:10 AM (364 w, 3 h)
Availability
Available

Recent Activity

Jul 10 2014

sowedance added a comment to T5593: Firefox (some Linux only?) sometimes triggers overflow unintentionally in Differential.

Oh well the original FB post was talking about autoscrolling. Anyway I cannot really repro the regular mouse wheel scrolling scenario.

Jul 10 2014, 6:50 PM · Differential, Design
sowedance added a comment to T5593: Firefox (some Linux only?) sometimes triggers overflow unintentionally in Differential.

Our HEAD is 4a6d2e9 (D8792) but we do have the fix for T4987 in. I am not quite sure but I think the issue here is that when you are holding the mouse wheel and then move the mouse to scroll up/down (only supported by FF I guess). For other files in https://secure.phabricator.com/D9871 it works all fine, except resources/sql/autopatches/20140710.workerpriority.sql. Although there is no horizontal scroll bar showing up, somehow it is still preventing scrolling up/down if you start trying this scroll mode there.

Jul 10 2014, 6:43 PM · Differential, Design

Jun 24 2014

sowedance abandoned D8428: Keep the generated code collapsed if there are only lint warnings inline.
Jun 24 2014, 4:56 PM
sowedance abandoned D7701: Change the only place with MYISAM to InnoDB.
Jun 24 2014, 4:42 PM

May 19 2014

sowedance closed T5109: arc diff failed when there are binary files as Resolved.
May 19 2014, 8:34 PM · Arcanist
sowedance added a comment to T5109: arc diff failed when there are binary files.

Ah yes. This could be the one. Thanks Evan!

May 19 2014, 8:33 PM · Arcanist
sowedance added a comment to T5109: arc diff failed when there are binary files.

We actually have it.

May 19 2014, 7:52 PM · Arcanist
sowedance created T5109: arc diff failed when there are binary files.
May 19 2014, 6:23 PM · Arcanist

May 15 2014

sowedance added a comment to T5070: Feed publisher got broken after upgrade.

Oh damn thank you Evan!

May 15 2014, 8:44 PM · Phabricator
sowedance added a comment to T5070: Feed publisher got broken after upgrade.

I am at the 4/16 version. I think the hash is 4a6d2e9

May 15 2014, 8:34 PM · Phabricator
sowedance created T5070: Feed publisher got broken after upgrade.
May 15 2014, 7:05 PM · Phabricator

May 13 2014

sowedance created T5032: In diff view, make the LHS text copy-able.
May 13 2014, 1:30 AM · Differential

May 5 2014

sowedance added a comment to D8492: Lint engine seems to get null configuration manager in svn precommit hook workflow.

Ignore my actions - I am just trying out the new transaction features.

May 5 2014, 8:12 PM

Apr 29 2014

sowedance updated the diff for D8888: It should be also valid to have empty change under hg.

OK I am removing the other part. Testing comment editing

Apr 29 2014, 9:17 PM
sowedance updated the diff for D8889: Put a limit on the number of files showing in herald emails.

Yeah I was trying to save some time sorting but it might cause some confusion too. Do it after sorting.

Apr 29 2014, 5:26 PM
sowedance updated the diff for D8888: It should be also valid to have empty change under hg.

Ah I actually want to make that change but did not mean to put it in this change.
Anyway since it's already there, I'll live with it. The reason we want that is that we try to use arc
in some automated tools and sometimes the generated code could exceed the limit.

Apr 29 2014, 5:20 PM

Apr 28 2014

sowedance retitled D8889: Put a limit on the number of files showing in herald emails from to Put a limit on the number of files showing in herald emails.
Apr 28 2014, 10:45 PM
sowedance retitled D8888: It should be also valid to have empty change under hg from to It should be also valid to have empty change under hg.
Apr 28 2014, 10:28 PM

Apr 15 2014

sowedance accepted D8774: Make task queue more robust against long-running tasks.

Ah ok I got it. Thanks!

Apr 15 2014, 2:12 AM
sowedance added a comment to D8774: Make task queue more robust against long-running tasks.

Generally looks good to me. Just one concern on the commit parsing workflow: if we make the lease expiration 2hrs, in case of parsing failure, does that mean that commit won't be parsed for the next 2 hours? If that's the case, I am a little worried since there are quite a few internal tools relying on the commit parsing and the delay could cause some problems for us.

Apr 15 2014, 2:04 AM

Apr 14 2014

sowedance updated the diff for D8773: Give the commitownersparser a little more time.

Updated based on comments.

Apr 14 2014, 10:48 PM
sowedance updated the diff for D8773: Give the commitownersparser a little more time.

Add a little checking into the parser workers. Just return in case the commit is already imported to that level.

Apr 14 2014, 10:37 PM
sowedance retitled D8773: Give the commitownersparser a little more time from to Give the commitownersparser a little more time.
Apr 14 2014, 10:21 PM

Apr 11 2014

sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

One more question on the task daemon behavior: when a task failed (like herald worker) and the daemon restart after a short period, would it retry the failed task immediately since the lease is not expired yet? I read the code and my understanding is that we always get the unleased tasks first, but in production it seems to be failing repeatedly. I am confused on that a little bit.

Apr 11 2014, 10:21 PM · Design, Facebook
sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

Ah yes it is 4366, sorry.
Both tables have about 400+ GB (data+index). Yeah I'll explore the alternatives you mentioned for the files.
Actually we already have D7885 and D7887 in our instance. I'll try to dig out more detailed information how it is failing.

Apr 11 2014, 10:13 PM · Design, Facebook
sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

A few more issues popping up during the past few weeks - most are general issues and not quite related to the rebase, but I put them here for some initial discussion anyway. I'll file individual tasks later on.

  1. Data compression. Some tables are taking hundreds of GB nowadays and keep growing. We need to address it since the total DB size already reached 2.2 TB and the hard limit is 2.5TB. Two major ones are the file blob and the differential hunks. We can enable compression in the table level in MySQL, but it's not as efficient as field compression from php code.
  2. In configerator repo we have a folder with more than 16k files (all the sitevars). Open it in diffusion will flood and DOS the whole site. Should we limit the requests sent out here? Maybe only the ones that are visible on the screen should have the request out.
  3. Recently we had some issues with the herald rules when the commit is huge (a branch cut for example). Basically if the commit rule has a condition with diff content, it will fail there, and after the daemon restarts it will fail there again and so on. We should be able to handle this type of failures better, or maybe we should not try to get the diff content at all if we know it's going to be enormous.
  4. Related to 3, the repeatedly failing herald worker will generate some huge emails in each run, and flood the active task queue. All other tasks are essentially blocked. The task queue is roughly a FIFO queue without taking into consideration the task types.
Apr 11 2014, 9:25 PM · Design, Facebook

Apr 8 2014

sowedance updated the diff for D8717: Fix an issue in arc patch with git-svn.

Yep that works! Updated based on comments and tested on both git and git-svn.

Apr 8 2014, 5:45 PM

Apr 7 2014

sowedance retitled D8717: Fix an issue in arc patch with git-svn from to Fix an issue in arc patch with git-svn.
Apr 7 2014, 10:53 PM

Mar 11 2014

sowedance retitled D8492: Lint engine seems to get null configuration manager in svn precommit hook workflow from to Lint engine seems to get null configuration manager in svn precommit hook workflow.
Mar 11 2014, 10:13 PM

Mar 6 2014

sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

One more complaint from Facebook: could we bring the author name back to blame view?

Mar 6 2014, 10:04 PM · Design, Facebook
sowedance added a comment to D8429: Allow parenthesis in author name.

Ah yes. Not likely to have this kind of lines but still need to be considered. I'll change it and add some tests.

Mar 6 2014, 6:37 PM
sowedance added a comment to D8428: Keep the generated code collapsed if there are only lint warnings inline.

I didn't notice that. Yeah let me check.

Mar 6 2014, 6:35 PM

Feb 25 2014

sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

I've put up a paste P1075 for the custom code we try to apply during data migration for D7139. Please take a look if you have some time. I've tested it on a test tier and it works fine to me.

Feb 25 2014, 8:24 PM · Design, Facebook
sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

Yeah you are right we don't need to have special action on D7513 - just batch the DB queries to make the migration faster I think. For D7139, double writing is not that hard I think.
Also thanks for the heads up on new big migrations - I'll look into them later once the current ones are done. Unfortunately I am living in Seattle, so have to communicate with you this way or on IRC.

Feb 25 2014, 6:12 PM · Design, Facebook
sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

Hey Evan and Co. - I think it's better to communicate with you guys with our plan on upgrading phabricator, so that you won't see unexpected comments from Facebook. We want to upgrade to the version of Jan 2014 this time, but there are a couple big data migrations we need to take additional care of. So the whole process will have five pushes:

  • Move the production to before D7139
  • Do the migration part of D7139 live. The original script is taking too long for us - due to the size of our inline comment table and the location of the DB tier. So we are changing the script a little bit to batch the database access to speed it up (we can do it in 3 hours now). In order to do it live, the inline comment storage code is changed a little bit so it does double writing to both tables whenever inline comments are added/edited/deleted.
  • Remove the double writing code in last step, and apply all the code changes up to D7513
  • Do the migration part of D7513 live. Again we do similar things - batch database access, do double writing
  • Remove the double writing code in last step, and apply all the code changes to some point in Jan 2014 (somewhere around Jan 13 as I remember)
Feb 25 2014, 5:50 PM · Design, Facebook

Feb 21 2014

sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

Like this:

Feb 21 2014, 7:48 PM · Design, Facebook
sowedance added a comment to T4465: Facebook Updated Again? (Umbrella UI Feedback Task).

The z shortcut is fixed - we moved to the 10/19 version since there is a big migration we need to take special care of, and I picked the fix in for 'z' later yesterday.
The biggest complaint so far on UI is the big white header in diffusion - it seems to be some waste space with just a few menu items which are seldom used.

Feb 21 2014, 7:43 PM · Design, Facebook

Feb 18 2014

chad awarded T4324: Change notification server so it only alerts appropriate clients a Mountain of Wealth token.
Feb 18 2014, 7:07 AM · Aphlict, Facebook

Jan 31 2014

sowedance assigned T4366: Phabricator got overloaded when browsing directories with large number of files in diffusion to epriestley.
Jan 31 2014, 11:31 PM · Diffusion

Jan 15 2014

sowedance assigned T4324: Change notification server so it only alerts appropriate clients to epriestley.
Jan 15 2014, 8:06 PM · Aphlict, Facebook