Page MenuHomePhabricator

It should be also valid to have empty change under hg
ClosedPublic

Authored by sowedance on Apr 28 2014, 10:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 4:47 PM
Unknown Object (File)
Feb 10 2024, 7:30 AM
Unknown Object (File)
Jan 17 2024, 11:08 AM
Unknown Object (File)
Jan 6 2024, 9:03 AM
Unknown Object (File)
Dec 29 2023, 7:38 PM
Unknown Object (File)
Dec 14 2023, 4:15 AM
Unknown Object (File)
Dec 8 2023, 2:36 AM
Unknown Object (File)
Nov 14 2023, 12:33 AM
Subscribers

Details

Summary

Like git, it is also valid to have empty net change under hg. Should not throw if that is the case.

Test Plan

Tried on a hg repo.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sowedance retitled this revision from to It should be also valid to have empty change under hg.
sowedance updated this object.
sowedance edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.

Flag seems unrelated? Other fix is fine.

src/workflow/ArcanistDiffWorkflow.php
397–401 ↗(On Diff #21084)

Unrelated?

This revision now requires changes to proceed.Apr 29 2014, 11:49 AM
sowedance edited edge metadata.

Ah I actually want to make that change but did not mean to put it in this change.
Anyway since it's already there, I'll live with it. The reason we want that is that we try to use arc
in some automated tools and sometimes the generated code could exceed the limit.

I'll accept the hg change, but I think we should separate out the other flag. See also T4924. I'd like to understand the larger context.

sowedance edited edge metadata.

OK I am removing the other part. Testing comment editing

This revision is now accepted and ready to land.Apr 29 2014, 9:17 PM
epriestley updated this revision to Diff 21131.

Closed by commit rARCc4ec22b140db (authored by @sowedance, committed by @epriestley).