Paths

Table of Contentst

Differential D8888

It should be also valid to have empty change under hg
ClosedPublic
Actions

Authored by • sowedance on Apr 28 2014, 10:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 8:47 AM

	Unknown Object (File)
	Tue, Dec 10, 2:39 PM

	Unknown Object (File)
	Thu, Dec 5, 7:49 AM

	Unknown Object (File)
	Thu, Dec 5, 7:43 AM

	Unknown Object (File)
	Thu, Dec 5, 6:43 AM

	Unknown Object (File)
	Fri, Nov 29, 11:39 AM

	Unknown Object (File)
	Fri, Nov 29, 11:17 AM

	Unknown Object (File)
	Fri, Nov 29, 11:04 AM

Subscribers

Details

Reviewers

epriestley
lifeihuang

Group Reviewers

Blessed Reviewers

Commits

rARCc4ec22b140db: It should be also valid to have empty change under hg

Summary

Like git, it is also valid to have empty net change under hg. Should not throw if that is the case.

Test Plan

Tried on a hg repo.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

• sowedance updated this revision to Diff 21084.Apr 28 2014, 10:28 PM

• sowedance retitled this revision from to It should be also valid to have empty change under hg.

• sowedance updated this object.

• sowedance edited the test plan for this revision. (Show Details)

• sowedance added reviewers: epriestley, lifeihuang.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2014, 10:28 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B105: Diff 21084.Apr 28 2014, 10:30 PM

Flag seems unrelated? Other fix is fine.

src/workflow/ArcanistDiffWorkflow.php
397–401 ↗	(On Diff #21084)	Unrelated?

This revision now requires changes to proceed.Apr 29 2014, 11:49 AM

Ah I actually want to make that change but did not mean to put it in this change.
Anyway since it's already there, I'll live with it. The reason we want that is that we try to use arc
in some automated tools and sometimes the generated code could exceed the limit.

Harbormaster completed remote builds in B121: Diff 21110.Apr 29 2014, 5:21 PM

I'll accept the hg change, but I think we should separate out the other flag. See also T4924. I'd like to understand the larger context.

OK I am removing the other part. Testing comment editing

Thanks!

This revision is now accepted and ready to land.Apr 29 2014, 9:17 PM

Closed by commit rARCc4ec22b140db (authored by @sowedance, committed by @epriestley).

Harbormaster completed remote builds in B133: Diff 21130.Apr 29 2014, 9:18 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBaseWorkflow.php

8 lines

Diff 21131

src/workflow/ArcanistBaseWorkflow.php

Loading...