Page MenuHomePhabricator
Differential D8888

It should be also valid to have empty change under hg
ClosedPublic
Actions

Authored by • sowedance on Apr 28 2014, 10:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 5:33 PM
Unknown Object (File)
Thu, Oct 31, 6:01 PM
Unknown Object (File)
Oct 23 2024, 5:34 AM
Unknown Object (File)
Oct 22 2024, 12:04 PM
Unknown Object (File)
Oct 21 2024, 9:42 AM
Unknown Object (File)
Oct 18 2024, 12:38 PM
Unknown Object (File)
Oct 16 2024, 4:02 AM
Unknown Object (File)
Oct 14 2024, 3:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
lifeihuang
Group Reviewers
Blessed Reviewers
Commits
rARCc4ec22b140db: It should be also valid to have empty change under hg
Summary

Like git, it is also valid to have empty net change under hg. Should not throw if that is the case.

Test Plan

Tried on a hg repo.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

• sowedance updated this revision to Diff 21084.Apr 28 2014, 10:28 PM
• sowedance retitled this revision from to It should be also valid to have empty change under hg.
• sowedance updated this object.
• sowedance edited the test plan for this revision. (Show Details)
• sowedance added reviewers: epriestley, lifeihuang.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2014, 10:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B105: Diff 21084.Apr 28 2014, 10:30 PM
epriestley requested changes to this revision.Apr 29 2014, 11:49 AM
epriestley edited edge metadata.

Flag seems unrelated? Other fix is fine.

src/workflow/ArcanistDiffWorkflow.php
397–401 ↗(On Diff #21084)

Unrelated?

This revision now requires changes to proceed.Apr 29 2014, 11:49 AM
• sowedance updated this revision to Diff 21110.Apr 29 2014, 5:20 PM
• sowedance edited edge metadata.

Ah I actually want to make that change but did not mean to put it in this change.
Anyway since it's already there, I'll live with it. The reason we want that is that we try to use arc
in some automated tools and sometimes the generated code could exceed the limit.

Harbormaster completed remote builds in B121: Diff 21110.Apr 29 2014, 5:21 PM
epriestley added a comment.Apr 29 2014, 9:12 PM

I'll accept the hg change, but I think we should separate out the other flag. See also T4924. I'd like to understand the larger context.

• sowedance updated this revision to Diff 21130.EditedApr 29 2014, 9:17 PM
• sowedance edited edge metadata.

OK I am removing the other part. Testing comment editing

epriestley accepted this revision.Apr 29 2014, 9:17 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Apr 29 2014, 9:17 PM
epriestley closed this revision.Apr 29 2014, 9:17 PM
epriestley updated this revision to Diff 21131.

Closed by commit rARCc4ec22b140db (authored by @sowedance, committed by @epriestley).

Harbormaster completed remote builds in B133: Diff 21130.Apr 29 2014, 9:18 PM

Revision Contents
Changeset List

PathSize
src/
workflow/
8 lines

Diff 21131

View Options

src/workflow/ArcanistBaseWorkflow.php

Loading...
Phabricator · Built by Phacility