Page MenuHomePhabricator

arc diff failed when there are binary files
Closed, ResolvedPublic

Description

Error message and call stack:
[2014-05-17 17:21:15] EXCEPTION: (PhabricatorDataNotAttachedException) Attempting to access attached data on DifferentialChangeset (via getHunks()), but the data is not actually attached. Before accessing attachable data on an object, you must load and attach it.\n\nData is normally attached by calling the corresponding needX() method on the Query class when the object is loaded. You can also call the corresponding attachX() method explicitly. at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:165]

#0 PhabricatorLiskDAO::assertAttached(<attachable>) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/differential/storage/DifferentialChangeset.php:43]
#1 DifferentialChangeset::getHunks() called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php:244]
#2 HeraldDifferentialRevisionAdapter::loadContentWithMask(1) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php:231]
#3 HeraldDifferentialRevisionAdapter::loadAddedContentDictionary() called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php:323]
#4 HeraldDifferentialRevisionAdapter::getHeraldField(diff-added-content) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/engine/HeraldEngine.php:357]
#5 HeraldEngine::getObjectFieldValue(diff-added-content) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/engine/HeraldEngine.php:349]
#6 HeraldEngine::getConditionObjectValue(Object HeraldCondition, Object HeraldDifferentialRevisionAdapter) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/engine/HeraldEngine.php:313]
#7 HeraldEngine::doesConditionMatch(Object HeraldRule, Object HeraldCondition, Object HeraldDifferentialRevisionAdapter) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/engine/HeraldEngine.php:270]
#8 HeraldEngine::doesRuleMatch(Object HeraldRule, Object HeraldDifferentialRevisionAdapter) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/engine/HeraldEngine.php:87]
#9 HeraldEngine::applyRules(Array of size 2417 starting with: { PHID-HRUL-uhavsbvx36etnqc5liln => Object HeraldRule }, Object HeraldDifferentialRevisionAdapter) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/herald/engine/HeraldEngine.php:42]
#10 HeraldEngine::loadAndApplyRules(Object HeraldDifferentialRevisionAdapter) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2058]
#11 PhabricatorApplicationTransactionEditor::applyHeraldRules(Object DifferentialRevision, Array of size 6 starting with: { 0 => Object DifferentialTransaction }) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:661]
#12 PhabricatorApplicationTransactionEditor::applyTransactions(Object DifferentialRevision, Array of size 6 starting with: { 0 => Object DifferentialTransaction }) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/differential/conduit/ConduitAPI_differential_Method.php:144]
#13 ConduitAPI_differential_Method::applyFieldEdit(Object ConduitAPIRequest, Object DifferentialRevision, Object DifferentialDiff, Array of size 6 starting with: { title => Reshimmed failing ReviewActionPerformerAsyncJobTest. }, null) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/differential/conduit/ConduitAPI_differential_createrevision_Method.php:49]
#14 ConduitAPI_differential_createrevision_Method::execute(Object ConduitAPIRequest) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/conduit/method/ConduitAPIMethod.php:67]
#15 ConduitAPIMethod::executeMethod(Object ConduitAPIRequest) called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/conduit/call/ConduitCall.php:163]
#16 ConduitCall::executeMethod() called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/conduit/call/ConduitCall.php:90]
#17 ConduitCall::execute() called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/src/applications/conduit/controller/PhabricatorConduitAPIController.php:91]
#18 PhabricatorConduitAPIController::processRequest() called at [/usr/local/fbprojects/packages/phabricator/frontend/122/devtools/phabricator/webroot/index.php:95]

Event Timeline

sowedance raised the priority of this task from to Needs Triage.
sowedance updated the task description. (Show Details)
sowedance added a subscriber: sowedance.

I think this was fixed by 6899fbcf2966bd3f37fb9dbba09df90651c17e11. Are you behind that?

HeraldEngine::applyRules(Array of size 2417 starting with...

Well, good to see people are using Herald.

Ah yes. This could be the one. Thanks Evan!

sowedance claimed this task.