Page MenuHomePhabricator

Lint engine seems to get null configuration manager in svn precommit hook workflow
ClosedPublic

Authored by sowedance on Mar 11 2014, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 6:22 PM
Unknown Object (File)
Sat, Mar 23, 4:44 PM
Unknown Object (File)
Wed, Mar 13, 1:06 PM
Unknown Object (File)
Wed, Mar 6, 6:12 AM
Unknown Object (File)
Tue, Feb 27, 11:14 PM
Unknown Object (File)
Feb 2 2024, 6:26 AM
Unknown Object (File)
Jan 24 2024, 7:56 PM
Unknown Object (File)
Jan 22 2024, 2:54 PM

Details

Summary

We recently tried to advance the arcanist HEAD in our release branch but failed, due to an exception in SVN pre-commit hook like this:

abort: Commit blocked by pre-commit hook (exit code 1) with output:
LINT 1.3s FacebookWebJSLintLinter (1 file)
Exception
Some linters failed:

  • FacebookWebCopyrightLinter: BadMethodCallException: Call to a member function getConfigFromAnySource() on a non-object

(Run with --trace for a full exception trace.)

However arc lint works just fine. By searching the change history, it looks related to a few commits D7271, D7377, D7382, especially D7377, where configuration manager is added to the lint engine. Add it to the SVN precommit hook workflow too.

Test Plan

I am not quite sure how to test it out easily. Any suggestions?

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sowedance retitled this revision from to Lint engine seems to get null configuration manager in svn precommit hook workflow.
sowedance updated this object.
sowedance edited the test plan for this revision. (Show Details)
sowedance added a subscriber: mikemag.
epriestley edited edge metadata.

This isn't particularly easy to test. You can do something like:

svnadmin create testroot
svn checkout file:///path/to/testroot testworkingcopy

...and then install a hook, and muck around with the test working copy. But this is fairly involved. There's no reasonable way to get an SVN transaction ID otherwise, though.

This revision is now accepted and ready to land.Mar 11 2014, 10:26 PM
epriestley updated this revision to Diff 20148.

Closed by commit rARCac82dea3c9e5 (authored by @sowedance, committed by @epriestley).

Ignore my actions - I am just trying out the new transaction features.