Page MenuHomePhabricator

Overflow in .differential-changeset causes dual scrollbars and interrupted scrolling
Closed, ResolvedPublic

Description

Noticed this on our own install after upgrading recently, and perhaps only in firefox (haven't tested much in Chrome), but the div with a class of differential-changeset gets a vertical scrollbar in certain situations (haven't determined what triggers it exactly), which can interrupt scrolling when you're trying to scroll down a long diff (as the div takes over the scrolling, but doesn't actually have any scrolling to do, outside of a few pixels).

It happens to me on this diff here on secure.phabricator.com:

https://secure.phabricator.com/D8999

Here's a screenshot of the dual scrollbars:

{F151214}

If I add overflow-y: hidden to the div (.differential-changeset CSS block) the scrollbar goes away and all seems ok, but not sure if hiding the vertical overflow on that div is acceptable or not.

Event Timeline

jaydiablo raised the priority of this task from to Needs Triage.
jaydiablo updated the task description. (Show Details)
jaydiablo added a project: Differential.
jaydiablo added a subscriber: jaydiablo.

Can you reproduce in Chrome? What version of Firefox?

Chrome doesn't seem to do it, Firefox 29 (OSX).

It also doesn't seem to happen on divs that have the code coverage gutter.

Yeah, it took me a while to repro this, you have to have your mouse in just the right place. There some overflow that shouldn't be happening. This area is also due for other tweaks with T4910: Handle large image files in Differential better. We should group those tasks together.

chad triaged this task as Low priority.May 15 2014, 10:10 PM