Sometimes a commit can be huge (like a branch cut in FB www which could have more than half a million files touched). It will generate some emails with size more than 30M, and it will take quite a while to just sort the files and to send out.
Put a hard limit here to avoid such cases. Probably only matters for FB right now, but still even for a small repo with several thousand files, it is a waste to send them all out. Not sure if there is any cleaner way to do it though.
Details
Details
- Reviewers
epriestley lifeihuang - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP3a0694543ddf: Put a limit on the number of files showing in herald emails
Tried it in FB installtion.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
We should limit files after calling sort() on them, so the user gets the first 1,000 files alphabetically, not 1,000 arbitrary files.
Comment Actions
Yeah I was trying to save some time sorting but it might cause some confusion too. Do it after sorting.