Everything in our database is on innodb except the search_documentfield table, which is still on MYISAM since it needs fulltext search. It needs to be changed for mysql upgrading (see task 2559259). The current innodb version should support fulltext already and I believe we actually do not really need the search database anymore since we are already using elastic search and this database was not updated for a long time.
For the production database, we can just do an alter table query, but we do have some tests that are initializing the databases. I am changing the sql scripts in release branch so that we will not cause errors in the database tier while pushing. Not quite sure if that's the right way to do though - let me know if you have any suggestions.
Details
- Reviewers
wez lifeihuang JoelB mikemag
Not tested.
Diff Detail
- Branch
- innodb
- Lint
Lint Errors Severity Location Code Message Error resources/sql/quickstart.sql:980 TXT2 Tab Literal Error src/aphront/configuration/AphrontDefaultApplicationConfiguration.php:88 PHL1 Unknown Symbol Error src/applications/auth/controller/PhabricatorEmailTokenController.php:54 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProvider.php:382 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderLDAP.php:33 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuth1.php:67 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuth1JIRA.php:53 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuth1Twitter.php:28 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthAmazon.php:39 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthAsana.php:31 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthDisqus.php:29 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthFacebook.php:40 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthGitHub.php:32 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthGoogle.php:32 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderOAuthTwitch.php:29 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderPassword.php:25 PHL1 Unknown Symbol Error src/applications/auth/provider/PhabricatorAuthProviderPersona.php:19 PHL1 Unknown Symbol Error src/applications/calendar/view/AphrontCalendarMonthView.php:90 PHL1 Unknown Symbol Error src/applications/conpherence/controller/ConpherenceNotificationPanelController.php:75 PHL1 Unknown Symbol Error src/applications/differential/landing/DifferentialLandingToGitHub.php:84 PHL1 Unknown Symbol Error src/applications/differential/render/DifferentialChangesetHTMLRenderer.php:253 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialAddCommentView.php:189 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialInlineCommentView.php:233 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialLocalCommitsView.php:131 PHL1 Unknown Symbol Error src/applications/differential/view/DifferentialRevisionCommentView.php:90 PHL1 Unknown Symbol - Unit
No Test Coverage
Event Timeline
I don't want to put this in the upstream, but this looks correct for Facebook.
(You can clear those lint warnings by updating libphutil/. You can identify which copy of libphutil/ to update by examining the first few lines of output from any arc command with the --trace flag.)
Someone at Facebook needs to look at this, as it's a local patch for Facebook's codebase only. @sowedance and I have talked about the issue and I'm in agreement that this is probably the best fix, given the context I have. Facebook does not use these tables, since it uses ElasticSearch instead.
(@sowedance, you could try using arc diff --conduit-uri=https://phabricator.fb.com/ to upload Facebook-only patches to Facebook's internal Phabricator, instead of the default public install. Not sure if you'll have better luck that way or not.)
Also, you can clear those lint warnings by updating libphutil/, as the error recommends:
Make sure libphutil and other libraries are up to date.
If you have several copies of libphutil/, you can identify which copy you need to update by examining the first few lines of output from arc <any command> --trace.
D7752 improves the error message for this lint warning to include more specific resolution steps.
Error (PHL1) Unknown Symbol
Use of unknown class 'BlerpBarp'. Common causes are:
- Your libphutil/ is out of date.
This is the most common cause.
Update this copy of libphutil: /INSECURE/devtools/libphutil
- Some other library is out of date.
Update the library this symbol appears in.
- This symbol is misspelled.
Spell the symbol name correctly.
Symbol name spelling is case-sensitive.
- This symbol was added recently.
Run `arc liberate` on the library it was added to.
- This symbol is external. Use `@phutil-external-symbol`.
Use `grep` to find usage examples of this directive.
*** ALTHOUGH USUALLY EASY TO FIX, THIS IS A SERIOUS ERROR.
*** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.Please take a quick look. Every time we do a push, we are generating some unittest databases breaking the replication.