Page MenuHomePhabricator

Apply "enormous changes" rules to pre-commit content rules too
ClosedPublic

Authored by epriestley on Jan 3 2014, 9:33 PM.
Tags
None
Referenced Files
F15457051: D7887.id17866.diff
Sun, Mar 30, 2:00 PM
F15428004: D7887.id17846.diff
Sun, Mar 23, 5:37 PM
F15403654: D7887.id.diff
Tue, Mar 18, 4:19 AM
F15340431: D7887.diff
Mar 9 2025, 3:11 PM
F15294454: D7887.id17866.diff
Mar 5 2025, 8:13 AM
F15294453: D7887.id17846.diff
Mar 5 2025, 8:13 AM
F15294451: D7887.id.diff
Mar 5 2025, 8:13 AM
F15282722: D7887.id17866.diff
Mar 4 2025, 1:47 AM
Subscribers

Details

Summary

Fixes T4276. This adds "Change is enormous" to pre-commit content rules so we can, e.g., just reject these and not worry about them elsewhere.

Also, use the same numeric limits across the mechanisms so there's a consistent definition of an "enormous" changeset.

Test Plan
  • Set enormous limit to 15 bytes, pushed some changes, got blocked by a rule.
  • Set it back, pushed OK.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped