Page MenuHomePhabricator

Apply "enormous changes" rules to pre-commit content rules too
ClosedPublic

Authored by epriestley on Jan 3 2014, 9:33 PM.
Tags
None
Referenced Files
F13529237: D7887.diff
Fri, Jul 26, 9:35 PM
Unknown Object (File)
Thu, Jul 25, 5:14 PM
Unknown Object (File)
Tue, Jul 23, 12:44 AM
Unknown Object (File)
Mon, Jul 22, 11:51 PM
Unknown Object (File)
Mon, Jul 22, 11:47 PM
Unknown Object (File)
Sat, Jul 20, 9:45 PM
Unknown Object (File)
Wed, Jul 17, 1:03 PM
Unknown Object (File)
Sat, Jul 13, 3:34 AM
Subscribers

Details

Summary

Fixes T4276. This adds "Change is enormous" to pre-commit content rules so we can, e.g., just reject these and not worry about them elsewhere.

Also, use the same numeric limits across the mechanisms so there's a consistent definition of an "enormous" changeset.

Test Plan
  • Set enormous limit to 15 bytes, pushed some changes, got blocked by a rule.
  • Set it back, pushed OK.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped