Page MenuHomePhabricator

Apply "enormous changes" rules to pre-commit content rules too
ClosedPublic

Authored by epriestley on Jan 3 2014, 9:33 PM.
Tags
None
Referenced Files
F13332540: D7887.id17846.diff
Mon, Jun 17, 2:19 PM
F13324323: D7887.diff
Fri, Jun 14, 11:35 PM
F13311555: D7887.diff
Tue, Jun 11, 5:12 AM
F13297977: D7887.diff
Fri, Jun 7, 6:09 AM
F13281338: D7887.diff
Sun, Jun 2, 10:34 AM
F13279792: D7887.id17866.diff
Sat, Jun 1, 11:09 PM
F13279791: D7887.id17846.diff
Sat, Jun 1, 11:09 PM
F13279790: D7887.id.diff
Sat, Jun 1, 11:09 PM
Subscribers

Details

Summary

Fixes T4276. This adds "Change is enormous" to pre-commit content rules so we can, e.g., just reject these and not worry about them elsewhere.

Also, use the same numeric limits across the mechanisms so there's a consistent definition of an "enormous" changeset.

Test Plan
  • Set enormous limit to 15 bytes, pushed some changes, got blocked by a rule.
  • Set it back, pushed OK.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped