Page MenuHomePhabricator

Apply "enormous changes" rules to pre-commit content rules too
ClosedPublic

Authored by epriestley on Jan 3 2014, 9:33 PM.
Tags
None
Referenced Files
F18101541: D7887.id17866.diff
Sat, Aug 9, 2:18 PM
F18098734: D7887.id17846.diff
Fri, Aug 8, 10:56 PM
F18096387: D7887.id.diff
Aug 8 2025, 6:36 AM
F18093122: D7887.diff
Aug 7 2025, 3:47 PM
Unknown Object (File)
May 8 2025, 1:09 PM
Unknown Object (File)
May 6 2025, 6:18 AM
Unknown Object (File)
Apr 30 2025, 12:44 PM
Unknown Object (File)
Apr 30 2025, 12:58 AM
Subscribers

Details

Summary

Fixes T4276. This adds "Change is enormous" to pre-commit content rules so we can, e.g., just reject these and not worry about them elsewhere.

Also, use the same numeric limits across the mechanisms so there's a consistent definition of an "enormous" changeset.

Test Plan
  • Set enormous limit to 15 bytes, pushed some changes, got blocked by a rule.
  • Set it back, pushed OK.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped