Not sure if this is the same issue, this is on a new phacility hosted phabricator instance, when attempting to push to a new mercurial repo:

I think it makes sense to abandon this until T7715 is sorted. Once that's figured out, I can resubmit a patch.

Cool, thanks for the detailed response. I'll close this as *invalid* since it's expected behaviour.

In T9216#132880, @epriestley wrote:

Does that output make sense in explaining what arc diff is doing, or not so much?

Sure thing, P1845

In T9172#132019, @chad wrote:

comment

Badge Please!

In T2495#61363, @epriestley wrote:

Okay, let's do this:

• I'll add a "View Options > Set Tab Width..." option as part of T5179 to handle one-off cases and reduce our need to get everything right. This will let you reload a file, rendering it at a different tab width.

In T6526#125777, @chad wrote:

You mean this: https://secure.phabricator.com/uiexample/view/PHUIBadgeExample/

I always thought it would be cool to reward stuff like:

My current team also has the workflow that a diff can't be landed until everyone on the team has reviewed it. We're working around this socially for the moment as suggested, but it would definitely be handy to have a "require all reviewers to accept before accepting" toggle. Judging by past experience with the phabulous phabricator team though... when this feature comes it will be well thought out and work very well. Thanks for all the work!

Just out of curiosity are you using the "auth.email-domains" feature?

Played a bit with the most recent implementation of this (7c96ba4ced4825b659286f1ecd55e954408b685c) and it seems to work quite well for my use case. We had a few reviews with various comments on different versions, and for the most part, I'm pretty happy with how the current code is pulling them forward. It's not perfect, there are a few cases where stuff is out of context, but I'm partial to having the comment there anyway so I don't forget about it completely, and can go back to the previous diff to read it in context if needed.

Was stuck with this same problem, just pulled the latest changes and can now report that it's working fine. Thanks!

I didn't see an easy way around having 2 foreach loops now... but, I might just be tired.

Implement requested changes, avoid N+1 Query Problem, and clean up output.