Page MenuHomePhabricator
Feed Advanced Search

May 14 2018

epriestley renamed T13137: Plans: 2018 Week 19 - Week 22 Bonus Content from Plans: 2018 Week 19 Bonus Content to Plans: 2018 Week 19 / Week 20 Bonus Content.
May 14 2018, 3:56 PM · Plans
epriestley updated the task description for T13133: Phabricator Query Layer Overview.
May 14 2018, 3:52 PM · Guides
epriestley triaged T13138: Improve consistency of MFA requirements to invite/approve users as Wishlist priority.
May 14 2018, 2:14 PM · People, Security
tanami awarded T13133: Phabricator Query Layer Overview a Dat Boi token.
May 14 2018, 6:01 AM · Guides

May 11 2018

jcox awarded T13133: Phabricator Query Layer Overview a Mountain of Wealth token.
May 11 2018, 7:37 PM · Guides

May 10 2018

epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 10 2018, 5:21 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Restricted Differential Revision.
May 10 2018, 5:19 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 10 2018, 5:02 PM · Plans

May 9 2018

epriestley closed T1246: Intraline diff bailout at 80 characters is inflexible and undesirable as Resolved by committing Restricted Diffusion Commit.
May 9 2018, 8:38 PM · Differential
epriestley added a comment to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable.

D19442 is marked as fixing this, although it just raises the limit from 80 to 100. This span measures the number of characters between the first changed character and the last changed character (not the total number of characters on the line) and we haven't seen tons of interest in this over the last several years so I think few installs are running into issues with it even at 80. Bumping it to 100 should give us a bit more breathing room but I don't currently plan to make it configurable (see T8227).

May 9 2018, 8:37 PM · Differential
epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 9 2018, 8:33 PM · Plans
epriestley added a revision to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable: Unknown Object (Differential Revision).
May 9 2018, 8:33 PM · Differential
epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 9 2018, 6:43 PM · Plans

May 8 2018

am9obgo awarded T418: Integrate CustomField into more interfaces a Like token.
May 8 2018, 5:46 AM · Restricted Project, Restricted Project, Restricted Project, Custom Fields, Maniphest

May 7 2018

epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 7 2018, 9:20 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 7 2018, 8:50 PM · Plans
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
May 7 2018, 7:30 PM · Arcanist, Plans
epriestley added a comment to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.

An install would like a way to filter commits by a particular branch, plus normal filter criteria.

May 7 2018, 5:54 PM · Plans
G3292 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
May 7 2018, 11:59 AM · Workboards (v3), Restricted Project

May 6 2018

epriestley closed T13130: Plans: 2018 Week 17/18 Bonus Content as Resolved.

Some of this moved forward to T13137.

May 6 2018, 4:07 PM · Plans
epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 6 2018, 1:47 PM · Plans
epriestley triaged T13137: Plans: 2018 Week 19 - Week 22 Bonus Content as Normal priority.
May 6 2018, 1:45 PM · Plans
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 6 2018, 1:35 PM · Plans
epriestley edited the content of Changelog.
May 6 2018, 12:03 PM
epriestley created 2018 Week 18 (Early May).
May 6 2018, 12:03 PM

May 4 2018

epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 10:11 PM · Plans
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
May 4 2018, 8:44 PM · Mail
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 8:44 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 8:30 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 7:33 PM · Plans
epriestley updated the task description for T13115: Handle mail bounces inside Phabricator.
May 4 2018, 6:42 PM · Mail
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 4 2018, 5:58 PM · Plans
epriestley closed T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4" as Resolved by committing Restricted Diffusion Commit.
May 4 2018, 4:28 PM · Files
epriestley added a revision to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4": Unknown Object (Differential Revision).
May 4 2018, 4:25 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

I like that reasoning a lot better than mine, and simply omitting type appears to produce the correct behavior in every browser, at least for this file. I'll try that instead, and we can revisit this after we write a video transcoder in PHP and can offer files in multiple formats.

May 4 2018, 3:14 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

I can imagine that two <source /> tags might, in some bizarre world, cause browsers to download the file twice when you click "Play", if they're super confused about how to process videos, don't notice that the URLs are the same, and don't hit any caching. But that's a pretty minor bad effect, and I didn't immediately see any kind of bad behavior locally.

May 4 2018, 2:50 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

Thanks! I wouldn't mind parsing that but I'm hesitant to ask installs to install it -- but it's helpful in understanding that I'm not completely crazy here and that there's at least some basis for "video/mp4" being a quasi-legitimate way to label the video file.

May 4 2018, 2:47 PM · Files

May 3 2018

epriestley updated the task description for T13133: Phabricator Query Layer Overview.
May 3 2018, 3:57 PM · Guides
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

One easy approach we could take is just:

May 3 2018, 3:45 PM · Files
epriestley triaged T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4" as Normal priority.
May 3 2018, 3:31 PM · Files

May 2 2018

epriestley added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

An install is hitting the "large blame does not degrade gracefully" issue mentioned in that task

May 2 2018, 3:42 AM · Plans
scp awarded T182: Commit into repository directly from differential a Love token.
May 2 2018, 12:45 AM · Haskell.org, Restricted Project, Differential

May 1 2018

epriestley closed T13132: `arc download` broken for non-CDN Phabricator as Resolved by committing Restricted Diffusion Commit.
May 1 2018, 5:08 PM · Conduit, Files
epriestley added projects to T13132: `arc download` broken for non-CDN Phabricator : Files, Conduit.
May 1 2018, 4:06 PM · Conduit, Files
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 1 2018, 2:24 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 1 2018, 2:24 PM · Plans
epriestley added a revision to T13132: `arc download` broken for non-CDN Phabricator : Unknown Object (Differential Revision).
May 1 2018, 2:21 PM · Conduit, Files
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 1 2018, 12:10 AM · Plans

Apr 30 2018

asherkin awarded T13133: Phabricator Query Layer Overview a Mountain of Wealth token.
Apr 30 2018, 10:35 PM · Guides
epriestley assigned T12164: Put an indirection layer between author/committer strings and user accounts to amckinley.
Apr 30 2018, 10:15 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

See PHI594, where a real user had the same human name as an external user from another project.

Apr 30 2018, 10:15 PM · Customer Impact, Diffusion (v3)
epriestley updated the task description for T13134: Give Conduit API tokens PHIDs, transactions, and other modern capabilities.
Apr 30 2018, 9:34 PM · Conduit
epriestley triaged T13134: Give Conduit API tokens PHIDs, transactions, and other modern capabilities as Normal priority.
Apr 30 2018, 9:33 PM · Conduit
scp awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a Piece of Eight token.
Apr 30 2018, 7:53 PM · Design, Differential, Plans
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 30 2018, 7:23 PM · Plans
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 30 2018, 7:15 PM · Plans, Differential
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 30 2018, 7:15 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 30 2018, 6:55 PM · Plans
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 30 2018, 6:55 PM · Plans, Differential
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 30 2018, 6:47 PM · Plans, Differential
epriestley updated the task description for T13133: Phabricator Query Layer Overview.
Apr 30 2018, 1:54 PM · Guides
epriestley triaged T13133: Phabricator Query Layer Overview as Normal priority.
Apr 30 2018, 12:55 PM · Guides
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 30 2018, 12:20 PM · Plans

Apr 29 2018

am9obgo awarded T3569: Make Phrequent somewhat usable a Like token.
Apr 29 2018, 12:30 PM · Phrequent

Apr 28 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 28 2018, 1:55 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 28 2018, 1:55 PM · Plans
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

From PHI604, for completeness, on the newer behavior of "Hide Blame":

Apr 28 2018, 1:52 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 28 2018, 1:14 PM · Plans
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 28 2018, 12:13 PM · Plans

Apr 27 2018

epriestley renamed T13130: Plans: 2018 Week 17/18 Bonus Content from Plans: 2018 Week 17 Bonus Content to Plans: 2018 Week 17/18 Bonus Content.
Apr 27 2018, 11:42 PM · Plans
epriestley edited the content of Changelog.
Apr 27 2018, 10:55 PM
epriestley created 2018 Week 17 (Very Late April).
Apr 27 2018, 10:54 PM
epriestley added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

validation for the configuration option

Apr 27 2018, 7:00 PM · Files, Aphront, Infrastructure
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 27 2018, 6:55 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 27 2018, 6:26 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 27 2018, 6:16 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 27 2018, 6:00 PM · Plans
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 27 2018, 5:56 PM · Plans

Apr 26 2018

epriestley added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

Just to make sure we're talking about the same thing, that feedback is true even of the version at HEAD (blue/grey/orange) vs the version that originally shipped (green/grey/red)?

Apr 26 2018, 10:48 PM · Design, Differential, Plans
epriestley added a comment to T13127: Plans: Form Steering Committee For "+/-" Line Indicators.

I think there's possibly at least some argument that this element could serve noble goals:

Apr 26 2018, 10:37 PM · Design, Differential, Plans

Apr 25 2018

epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

I suppose the approach proposed above gets a questionable result here:

Apr 25 2018, 8:43 PM · Policy, PHUI, Phriction
epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

After actually looking at the code, it looks like null can already be returned and works, it's just kind of wrong for some objects (like Dashboards) because they really do have a default policy -- it's just hard-coded.

Apr 25 2018, 8:28 PM · Policy, PHUI, Phriction
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 25 2018, 6:16 PM · Plans
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See PHI612 and elsewhere; using "Take action [the first time this rule matches]" isn't always obvious but is usually a better fit than "When [ thing is created ]" and interacts much better with drafts.

Apr 25 2018, 4:48 PM · Restricted Project, Herald
epriestley updated the task description for T2312: Modifying PHP.
Apr 25 2018, 4:31 PM · Infrastructure
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 25 2018, 4:30 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 25 2018, 2:33 PM · Plans
epriestley added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

A 600MB patch should not take 3 hours to encode. We should reproduce this and fix whatever the problem is (buffer appends or otherwise), or clearly document why we actually can't fix it.

Apr 25 2018, 2:15 PM · Plans
epriestley added a revision to T13103: Document favicon customization and validate the "ui.favicons" configuration option: Unknown Object (Differential Revision).
Apr 25 2018, 1:45 PM · Files, Aphront, Infrastructure

Apr 24 2018

epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 24 2018, 10:43 PM · Plans
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
Apr 24 2018, 4:29 PM · Plans
epriestley added a comment to T13128: Phriction document header doesn't render policy strength variations.

I'm going to tentatively put this (the Phriction rule, specifically) into T13130 for this week although I'm not sure how much work getting getDefaultPolicyForObject() to return the root document policy is and maybe that's Unbelievably Difficult. Let me take a quick look at that and you can either run with it or I can pick it up if it's some kind of weird arcana.

Apr 24 2018, 4:26 PM · Policy, PHUI, Phriction
ermik awarded T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud) a Like token.
Apr 24 2018, 12:11 PM

Apr 23 2018

epriestley updated the task description for T13065: Move storage for `mailKey` to the Mail application.
Apr 23 2018, 9:23 PM · Mail
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

Ah, yeah. No idea why I typed "blind" instead.

Apr 23 2018, 9:23 PM · Mail
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
Apr 23 2018, 9:07 PM · Plans
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Apr 23 2018, 9:01 PM · Mail
epriestley added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

One option is to write "Herald Rules for Herald Rules".

Apr 23 2018, 3:09 AM · Plans

Apr 22 2018

epriestley added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

Offhand, two possible issues with that:

Apr 22 2018, 9:29 PM · Plans
epriestley added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

See PHI580. An install would like write API access to object relationships (depends on, fixes, etc). This is complicated, but perhaps plannable, and we may be able to put a reasonable facade with partial support into the upstream.

Apr 22 2018, 3:59 PM · Plans