Page MenuHomePhabricator
Feed Advanced Search

Mar 23 2018

epriestley updated the task description for T13112: Safari, PDFs, and Content-Security-Policy interact oddly.
Mar 23 2018, 11:50 AM · Safari, Security, Files
epriestley closed T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Resolved.

Actually, it seems like rel="noreferrer" fixes this. This is bizarre so maybe this is a problem with a spooky ghost haunting my computer?

Mar 23 2018, 11:48 AM · Safari, Security, Files
epriestley triaged T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Normal priority.
Mar 23 2018, 11:47 AM · Safari, Security, Files

Jul 9 2017

chad removed the image for Safari.
Jul 9 2017, 7:16 PM

Apr 5 2017

epriestley closed T8266: Some audio isn't streaming correctly in Safari as Resolved.

F60036 now plays correctly for me in Safari.

Apr 5 2017, 5:13 PM · Safari, Files
epriestley added a revision to T8266: Some audio isn't streaming correctly in Safari: D17624: Correct an issue where the wrong "Content-Length" was set for partial content responses.
Apr 5 2017, 1:53 PM · Safari, Files

Mar 30 2017

epriestley moved T8266: Some audio isn't streaming correctly in Safari from Backlog to vNext on the Files board.
Mar 30 2017, 7:34 PM · Safari, Files

Nov 21 2016

chad removed a watcher for Safari: chad.
Nov 21 2016, 6:57 PM
chad added a watcher for Safari: chad.
Nov 21 2016, 6:56 PM

Sep 23 2016

alex3d added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

Linux Chrome dev channel 55.0.2859.0 (64-bit) have no issues with image paste.
Seems that it is ChromeOS specific issue.

Sep 23 2016, 11:46 AM · Restricted Project, Firefox, Safari, PHUI

Sep 21 2016

epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

I can't reproduce this in Chrome (OS X, Version 53.0.2785.116 (64-bit)) so it may be a behavioral change in Chrome.

Sep 21 2016, 7:57 PM · Restricted Project, Firefox, Safari, PHUI
alex3d added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

I'm observing same issue in current ChromeOS 55.0.2858.0 dev branch.
At the same time image paste works in Telegram web client (seems that they use contentEditable div instead of textarea)
Do you know whether it's a chrome os bug or google deprecated DataTransfer.items in new chrome's?

Sep 21 2016, 7:31 PM · Restricted Project, Firefox, Safari, PHUI

Aug 5 2016

eadler moved T7916: Can't paste images from clipboard in Firefox / Safari from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 5 2016, 4:40 PM · Restricted Project, Firefox, Safari, PHUI

Jul 8 2016

epriestley added a comment to T11237: Mobile action menus are "undefined".

iiam

Jul 8 2016, 10:39 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

doesn't reproduce anymore

Jul 8 2016, 10:38 PM · Chad's House, Mobile, Safari, Bug Report
chad closed T11237: Mobile action menus are "undefined" as Spite.
Jul 8 2016, 10:38 PM · Chad's House, Mobile, Safari, Bug Report

Jul 2 2016

epriestley removed a project from T7916: Can't paste images from clipboard in Firefox / Safari: Prioritized.
Jul 2 2016, 7:17 PM · Restricted Project, Firefox, Safari, PHUI
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

This doesn't appear to even to be possible in Firefox. Here's a simple example:

Jul 2 2016, 4:31 PM · Restricted Project, Firefox, Safari, PHUI
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

From the Firefox bug and this linked one:

Jul 2 2016, 3:44 PM · Restricted Project, Firefox, Safari, PHUI

Jul 1 2016

epriestley added a comment to T11237: Mobile action menus are "undefined".

Truly our most useful project.

Jul 1 2016, 10:22 PM · Chad's House, Mobile, Safari, Bug Report
chad added a project to T11237: Mobile action menus are "undefined": Chad's House.

Wait for it...

Jul 1 2016, 10:21 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a project to T7916: Can't paste images from clipboard in Firefox / Safari: Prioritized.
Jul 1 2016, 9:35 PM · Restricted Project, Firefox, Safari, PHUI
eadler added a project to T7916: Can't paste images from clipboard in Firefox / Safari: Restricted Project.
Jul 1 2016, 9:28 PM · Restricted Project, Firefox, Safari, PHUI
epriestley merged T11253: Make it possible to paste images into T7916: Can't paste images from clipboard in Firefox / Safari.
Jul 1 2016, 7:19 PM · Restricted Project, Firefox, Safari, PHUI

Jun 30 2016

tide added a comment to T11237: Mobile action menus are "undefined".

Happens on test account too

Jun 30 2016, 3:14 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T11237: Mobile action menus are "undefined".

I tried a couple of other devices in the simulator but couldn't get a repro -- can you try this to get a JS trace?

Jun 30 2016, 2:35 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

Let me try my spam account.

Jun 30 2016, 2:30 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

Image.png (1×750 px, 108 KB)

Jun 30 2016, 2:27 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T11237: Mobile action menus are "undefined".

Nothing unusual. Latest iPhone/iOS

Jun 30 2016, 2:26 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T11237: Mobile action menus are "undefined".

I can't immediately reproduce this in iOS Simulator or on my physical iPhone 4s. What hardware/OS version are you seeing it on?

Jun 30 2016, 2:24 PM · Chad's House, Mobile, Safari, Bug Report
epriestley added a comment to T11237: Mobile action menus are "undefined".

image.jpg (960×640 px, 108 KB)

Jun 30 2016, 2:23 PM · Chad's House, Mobile, Safari, Bug Report
epriestley claimed T11237: Mobile action menus are "undefined".
Jun 30 2016, 2:20 PM · Chad's House, Mobile, Safari, Bug Report
chad updated the task description for T11237: Mobile action menus are "undefined".
Jun 30 2016, 4:27 AM · Chad's House, Mobile, Safari, Bug Report

Feb 24 2016

tycho.tatitscheff added a comment to T10444: Ever make a mistake? Catch it before its too late.??.

Quoting for the main page :

Feb 24 2016, 12:16 PM
Persona created T10444: Ever make a mistake? Catch it before its too late.??.
Feb 24 2016, 11:35 AM

Feb 2 2016

chad updated the image for Safari from F1076471: profile to F1087348: profile.
Feb 2 2016, 4:58 PM

Jan 29 2016

aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Works for me on the iPad Pro. Thank you!

Jan 29 2016, 7:02 PM · Safari, Mobile, Bug Report
chad added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Seems OK for me on a physical iPhone 4s.

Jan 29 2016, 4:02 PM · Safari, Mobile, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

This is live on this server (secure.phabricator.com) -- let us know if you're still seeing issues. Seems OK for me on a physical iPhone 4s.

Jan 29 2016, 2:59 PM · Safari, Mobile, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

This is now deployed to this server (secure.phabricator.com) -- let me know if you're still seeing issues? Behavior seems OK in the simulator and with my physical iPhone 4s, but I don't have a fancy physical 6s to test.

Jan 29 2016, 2:57 PM · Safari, Differential, Bug Report
epriestley closed T10229: In iOS Safari, buttons must be tapped twice to fire. as Resolved by committing rPbf43d4cf2aa6: Don't mutate DOM on touch-originated cursor events in Differential.
Jan 29 2016, 2:55 PM · Safari, Mobile, Bug Report
epriestley closed T9969: Differential 1-up render doesn't trigger on iOS as Resolved by committing rPdbf1d0d7210f: Improve reliability of detecting small devices when loading Differential….
Jan 29 2016, 2:55 PM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Specifically, this is my best guess at what's going on:

Jan 29 2016, 2:55 PM · Safari, Differential, Bug Report
epriestley claimed T9969: Differential 1-up render doesn't trigger on iOS.
Jan 29 2016, 2:48 PM · Safari, Differential, Bug Report
epriestley claimed T10229: In iOS Safari, buttons must be tapped twice to fire..
Jan 29 2016, 2:47 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Yep and to be honest this huge iPad is fairly desktop-y. The first time I saw it I kind of had to look twice to make sure it wasn't some run away item from Alice in Wonderland that had snuck into my reality.

Jan 29 2016, 2:20 PM · Safari, Mobile, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I've marked D15135 as fixing this out of a general abundance of sunny optimism.

Jan 29 2016, 1:58 PM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I think D15135 actually fixes this. I can't reproduce it in iOS Simulator after applying that patch.

Jan 29 2016, 1:57 PM · Safari, Differential, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

D15136 distinguishes between "touch-device" mouseovers and "mouse-device" mouseovers rather than relying on device detection, since the screen resolution of the iPad Pro is apparently a billion pixels by a trillion pixels and device detection is clearly increasingly hopeless.

Jan 29 2016, 1:51 PM · Safari, Mobile, Bug Report
epriestley added a revision to T10229: In iOS Safari, buttons must be tapped twice to fire.: D15136: Don't mutate DOM on touch-originated cursor events in Differential.
Jan 29 2016, 1:49 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I gave this solution a quick whirl and it works. It preserves mouse over behaviour in regular browsers, and removes the need for double tapping in iOS (while still getting the selection highlights). Let me know if you'd like a patch or if you prefer your device detection approach.

Jan 29 2016, 1:31 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Yeah. On a pure touch device, mouseover is not the most useful event to listen for when it comes to highlighting rows.

Jan 29 2016, 1:15 PM · Safari, Mobile, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Nice work! I arrived at the same conclusion shortly after you did.

Jan 29 2016, 1:09 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I have found the bug. For iOS Safari to send a click event, the handlers of mouseover and mousemove must not change the document content. (Presumably to allow a touch user to reveal things that require mousing over, without actually clicking things.)

Jan 29 2016, 1:02 PM · Safari, Mobile, Bug Report
epriestley added a revision to T9969: Differential 1-up render doesn't trigger on iOS: D15135: Improve reliability of detecting small devices when loading Differential changesets.
Jan 29 2016, 1:00 PM · Safari, Differential, Bug Report
epriestley added a revision to T10229: In iOS Safari, buttons must be tapped twice to fire.: D15135: Improve reliability of detecting small devices when loading Differential changesets.
Jan 29 2016, 1:00 PM · Safari, Mobile, Bug Report
epriestley reopened T10229: In iOS Safari, buttons must be tapped twice to fire. as "Open".

I can reproduce this on my iPhone 4s which correctly selects 1-up mode, so I agree that this is probably not a duplicate of T9969.

Jan 29 2016, 12:57 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Okay I don't think it's related to the 1up vs 2up renderer. Reading the source code I found out that the "1up" renderer seems to be triggered for certain screen widths. So I used an iOS Split View to reduce the width of my browser until it was fairly narrow, and as result I got a unified diff instead, which I believe is the "1up" view.

Jan 29 2016, 12:04 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Not sure what the "1-up renderer" is but if it's 1 vs 2 columns, that's not the problem really. The formatting of the diff is fine (it's a large, desktop size screen).

Jan 29 2016, 10:02 AM · Safari, Mobile, Bug Report

Jan 28 2016

chad renamed T9969: Differential 1-up render doesn't trigger on iOS from 'Show 20 lines' broken on mobile Safari to Differential 1-up render doesn't trigger on iOS.
Jan 28 2016, 5:33 AM · Safari, Differential, Bug Report
chad added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

This now reproduces in Chrome/iOS as of Chrome 48 (they now use WKWebView like Safari does).

Jan 28 2016, 5:15 AM · Safari, Differential, Bug Report
chad updated subscribers of T9969: Differential 1-up render doesn't trigger on iOS.
Jan 28 2016, 5:14 AM · Safari, Differential, Bug Report
chad merged task T10229: In iOS Safari, buttons must be tapped twice to fire. into T9969: Differential 1-up render doesn't trigger on iOS.
Jan 28 2016, 5:14 AM · Safari, Mobile, Bug Report

Jan 27 2016

chad added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

See also T10229 for a similar Safari/Diff Render issue.

Jan 27 2016, 7:15 PM · Safari, Differential, Bug Report
chad updated subscribers of T10229: In iOS Safari, buttons must be tapped twice to fire..

Maaaybe an issue with how we detect and decide to use the 1-up renderer? cc @epriestley

Jan 27 2016, 6:46 PM · Safari, Mobile, Bug Report
chad added a project to T10229: In iOS Safari, buttons must be tapped twice to fire.: Safari.
Jan 27 2016, 6:43 PM · Safari, Mobile, Bug Report
chad added a project to T8266: Some audio isn't streaming correctly in Safari: Safari.
Jan 27 2016, 6:40 PM · Safari, Files
chad added projects to T7916: Can't paste images from clipboard in Firefox / Safari: Safari, Firefox.
Jan 27 2016, 6:40 PM · Restricted Project, Firefox, Safari, PHUI
chad added a project to T9969: Differential 1-up render doesn't trigger on iOS: Safari.
Jan 27 2016, 6:40 PM · Safari, Differential, Bug Report
chad updated the image for Safari from F1076468: fa-tags-blue.png to F1076471: profile.
Jan 27 2016, 6:39 PM
chad created Safari.
Jan 27 2016, 6:39 PM