Page MenuHomePhabricator

Correct an issue where the wrong "Content-Length" was set for partial content responses
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 11:08 PM
Unknown Object (File)
Mon, Feb 10, 8:23 PM
Unknown Object (File)
Sat, Feb 1, 11:34 PM
Unknown Object (File)
Tue, Jan 21, 3:57 PM
Unknown Object (File)
Tue, Jan 21, 9:23 AM
Unknown Object (File)
Dec 26 2024, 4:53 AM
Unknown Object (File)
Dec 21 2024, 12:35 PM
Unknown Object (File)
Dec 20 2024, 5:37 PM
Subscribers
None

Details

Summary

Ref T8266. Although we compute this correctly above, we ignored it when actually setting the header. Use the computed value to set the "Content-Length" header. This is consistent with the spec/documentation.

Test Plan

Before, some audio (like rain.mp3) was pretty spotty about loading in Safari. It now loads consistently for me locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable