contentID on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road.

The unit test results also don't currently show on individual builds, which is a little whack?

See T13189#240682 for some planning on the Unit Test result table.

See PHI710. This is a request for richer lint/unit results. It's likely entangled with T13088 but can probably be planned.

See PHI690. An install would like access to Drydock lease metrics, notably the time a lease spent in queue. See also T13073, but this is more narrowly scoped.

I kicked some user/profile/account stuff to T13190.

I landed D19586 (the thing which breaks T13186) and pushed it here. This generally causes us to perform more policy checks, and may cause new policy exceptions which did not exist before (because the workflows relied implicitly on weak policy enforcement). If these crop up, the remedy is generally to explicitly weaken the required capability for the action.

I punted the rest of this to T13189.

unless you believe this is just a different manifestation of the same underlying bug.

In T13187#240394, @epriestley wrote:

See PHI757. Leaving inline comments on the right hand side of files not touched by diff B in an interdiff between A and B raises an error.

This is at least somewhat involved. Related behavior:

• In the standalone view, you can leave comments on either side -- and they swap sides!
• Deleting comments from either side raises a JS error ("TypeError: null is not an object (evaluating 'templates.r')"). (Actually, this looks like it applies to all standalone deletion?)

See PHI757. Leaving inline comments on the right hand side of files not touched by diff B in an interdiff between A and B raises an error.