Page MenuHomePhabricator
Feed Advanced Search

Jul 23 2016

epriestley added a comment to T11351: Move Pholio to EditEngine and modern APIs.

(T11357 is a companion issue for Files.)

Jul 23 2016, 8:36 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Jul 21 2016

eadler removed a project from T2968: In conduit, make auto resolve task via review land look the same as manual resolve: Restricted Project.
Jul 21 2016, 7:18 PM · Restricted Project, Conduit
mose added a comment to T11351: Move Pholio to EditEngine and modern APIs.

Excellent! Thanks for this so very detailed answer. I will try the way of the phid.lookup to work this issue around in the while.

Jul 21 2016, 5:22 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from vMajor to API Changes on the Arcanist board.
Jul 21 2016, 11:55 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:45 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley moved T11351: Move Pholio to EditEngine and modern APIs from Backlog to v2 on the Pholio board.
Jul 21 2016, 11:05 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley renamed T11351: Move Pholio to EditEngine and modern APIs from Add a conduit API for pholio to Move Pholio to EditEngine and modern APIs.
Jul 21 2016, 11:05 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a comment to T11351: Move Pholio to EditEngine and modern APIs.

Thanks for the extra context!

Jul 21 2016, 11:04 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
eadler reopened T11351: Move Pholio to EditEngine and modern APIs as "Open".

reopening due to additional details

Jul 21 2016, 4:27 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
mose added a comment to T11351: Move Pholio to EditEngine and modern APIs.

Let me add some more detailed and specific information. We wrote (and released) https://github.com/Gandi/hubot-phabs

Jul 21 2016, 4:05 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Jul 20 2016

bapt updated the task description for T11351: Move Pholio to EditEngine and modern APIs.
Jul 20 2016, 10:40 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley closed T11351: Move Pholio to EditEngine and modern APIs as Invalid.

Please read Contributing Feature Requests carefully before filing feature requests. In particular, we need you to describe a root problem (see Describing Root Problems).

Jul 20 2016, 9:35 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
eadler added projects to T11351: Move Pholio to EditEngine and modern APIs: Pholio, Conduit.
Jul 20 2016, 6:13 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
jsturgeon updated Q448: Is there a way to update a differential comment using conduit? from to Is there a way to update a differential comment using conduit?.
Jul 20 2016, 12:20 AM · Conduit

Jul 17 2016

cinek added a comment to T11340: Add story points to maniphest conduit call responses.

I use maniphest.query (which is marked stable).

Jul 17 2016, 9:46 PM · Conduit, Maniphest, Feature Request
epriestley added a comment to T11340: Add story points to maniphest conduit call responses.

They're available in the "points" field of maniphest.search.

Jul 17 2016, 9:33 PM · Conduit, Maniphest, Feature Request
avivey closed T11340: Add story points to maniphest conduit call responses as Resolved.

maniphest.search method contains that under points:

pasted_file (445×383 px, 34 KB)

Jul 17 2016, 9:32 PM · Conduit, Maniphest, Feature Request
cinek created T11340: Add story points to maniphest conduit call responses.
Jul 17 2016, 9:14 PM · Conduit, Maniphest, Feature Request

Jul 13 2016

epriestley closed T7944: Add Conduit support to Calendar as Resolved.

calendar.event.search is still pretty useless/bare-bones (you don't get very much information back), but we can expand that as use cases arise. We don't have specific needs for this yet.

Jul 13 2016, 5:34 PM · Conduit, Calendar
epriestley added a revision to T7944: Add Conduit support to Calendar: Restricted Differential Revision.
Jul 13 2016, 3:43 PM · Conduit, Calendar
epriestley closed T9275: Move Calendar to EditEngine, a subtask of T7944: Add Conduit support to Calendar, as Resolved.
Jul 13 2016, 3:03 PM · Conduit, Calendar

Jul 12 2016

avivey moved T550: Build an SSH conduit client from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 12 2016, 9:55 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit

Jul 10 2016

epriestley closed T11304: Conduit "*.search" methods unnecessarily persist search queries as Resolved by committing Restricted Diffusion Commit.
Jul 10 2016, 3:04 PM · Performance, Conduit, Phacility

Jul 9 2016

epriestley added a comment to T11304: Conduit "*.search" methods unnecessarily persist search queries.

(Only unique queries are saved, so this should be a small amount of data in most cases, but the Phacility setup tends to mean we issue a lot of unique queries.)

Jul 9 2016, 1:51 PM · Performance, Conduit, Phacility
epriestley added a revision to T11304: Conduit "*.search" methods unnecessarily persist search queries: Restricted Differential Revision.
Jul 9 2016, 1:50 PM · Performance, Conduit, Phacility
epriestley created T11304: Conduit "*.search" methods unnecessarily persist search queries.
Jul 9 2016, 1:36 PM · Performance, Conduit, Phacility

Jul 5 2016

epriestley closed T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 11:45 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a revision to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input: Restricted Differential Revision.
Jul 5 2016, 11:40 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

A possible alternate approach would be to attachRepository() as a side-effect of validating the transaction instead of while applying the transaction, but then if something throws between the "validate" and "apply" steps we could end up with a URI in a weird state. That probably never actually matters, but feels a little more awkward to me than ordering the transactions.

Jul 5 2016, 11:34 PM · ApplicationEditor, Conduit, Bug Report
avivey added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

ok, that makes sense.

Jul 5 2016, 11:32 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

It's impossible to create a URI without a repository transaction (it doesn't make sense, since URI objects can't just exist), and we already give you an appropriate error when you try:

Jul 5 2016, 11:31 PM · ApplicationEditor, Conduit, Bug Report
avivey added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

That kinda feels like a band-aid... Shouldn't we be able to not-crash for any input? Like if a user will only provide a uri transaction?

Jul 5 2016, 11:22 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

My initial thought is that we should just reorder these transactions. We should use a stable sort, but that's relatively easy now that we have msortv(). There are probably a handful of other transactions with similar properties in other object types.

Jul 5 2016, 9:10 PM · ApplicationEditor, Conduit, Bug Report
avivey renamed T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input from diffusion.uri.edit fails depending on order of transactions in input to diffusion.uri.edit for creating an object fails depending on order of transactions in input.
Jul 5 2016, 8:43 PM · ApplicationEditor, Conduit, Bug Report
avivey created T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.
Jul 5 2016, 8:42 PM · ApplicationEditor, Conduit, Bug Report
jack.chung added a comment to T10456: Conduit interprets all arguments from curl requests as strings.

if it helps anyone, the workaround "fix" is to place the following code in the file "src/applications/conduit/parametertype/ConduitBoolParameterType.php "

Jul 5 2016, 8:26 PM · Restricted Project, Conduit, Bug Report
vit0p updated Q439: There is a conduit method to retrieve differentials attached to a maniphest task? from to There is a conduit method to retrieve differentials attached to a maniphest task?.
Jul 5 2016, 10:51 AM · Differential, Maniphest, Conduit

Jul 4 2016

eadler moved T10681: Add Phurl Conduit API methods from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:19 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
eadler moved T10671: Implement `badges.search` and `badges.edit` Conduit API methods from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:19 PM · Restricted Project, Conduit, Badges (v0)
eadler moved T9766: Expose conduit API to activate/disable Herald rules from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:19 PM · Restricted Project, Restricted Project, Conduit, Herald
eadler moved T4184: API does not contain user.create from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, FreeBSD, Conduit, Auth
eadler moved T6643: Conduit method for adding SSH keys to a user's account from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:17 PM · Restricted Project, Conduit
eadler moved T2968: In conduit, make auto resolve task via review land look the same as manual resolve from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:15 PM · Restricted Project, Conduit
eadler moved T550: Build an SSH conduit client from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:15 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
eadler moved T7303: Provide OAuth access to Conduit from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:15 PM · Restricted Project, Conduit, Restricted Project
eadler moved T10516: Harbormaster Conduit API to build from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:10 PM · Restricted Project, Conduit, Harbormaster, Feature Request
eadler moved T9063: Conduit application search from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:09 PM · Contributor Onboarding, Restricted Project, Conduit
eadler moved T10272: Expose "branched from" information in conduit differential API from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:05 PM · Restricted Project, Conduit, Feature Request

Jul 3 2016

epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

Turns out that CustomFields sort of just work properly with EditEngine out of the box, so D16226 provides a technically-functional dashboard.panel.edit, which allows you to edit text panels like this, for example:

Jul 3 2016, 10:12 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a revision to T10855: Allow external systems to edit the content of dashboard panels so they can publish information: Restricted Differential Revision.
Jul 3 2016, 9:47 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Backlog to v2 on the Dashboards board.
Jul 3 2016, 9:17 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

We probably need to do almost all of this work before adding new panel types anyway, since building a new panel type on top of CustomFields would make moving everything from CustomFields to EditEngine harder.

Jul 3 2016, 9:11 AM · Dashboards, Restricted Project, Conduit, Feature Request
eadler added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

FWIW we'd be perfectly fine with the following:

  • allow editing phriction documents via Conduit
  • create a panel which shows the contents of a specific phriction page
Jul 3 2016, 5:51 AM · Dashboards, Restricted Project, Conduit, Feature Request

Jul 2 2016

epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

The actual panel transactions that we need to update for this aren't too bad. The board transactions are a little more involved, but we can skip them.

Jul 2 2016, 7:36 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Preflight to The Queue on the Prioritized board.
Jul 2 2016, 7:24 PM · Dashboards, Restricted Project, Conduit, Feature Request

Jul 1 2016

epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

parrot

Jul 1 2016, 10:07 PM · Dashboards, Restricted Project, Conduit, Feature Request
chad added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

No, no I can't. I can't make a Phriction Panel.

Jul 1 2016, 9:59 PM · Dashboards, Restricted Project, Conduit, Feature Request
chad added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

I might be able make a Phriction Panel

Jul 1 2016, 9:53 PM · Dashboards, Restricted Project, Conduit, Feature Request

Jun 29 2016

• sshannin added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

FWIW, the answer to both of your questions before you edited it was yes :p

Jun 29 2016, 12:29 AM · Conduit, Arcanist, Bug Report
eadler added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

ignore me - wrong install

Jun 29 2016, 12:27 AM · Conduit, Arcanist, Bug Report
• sshannin added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

Thanks for such a quick response!

Jun 29 2016, 12:24 AM · Conduit, Arcanist, Bug Report

Jun 28 2016

epriestley closed T11222: arc hitting wrong url for conduit when not passed a full URI as Resolved by committing Restricted Diffusion Commit.
Jun 28 2016, 10:20 PM · Conduit, Arcanist, Bug Report
epriestley added a revision to T11222: arc hitting wrong url for conduit when not passed a full URI: Restricted Differential Revision.
Jun 28 2016, 9:45 PM · Conduit, Arcanist, Bug Report
epriestley added a revision to T11222: arc hitting wrong url for conduit when not passed a full URI: Restricted Differential Revision.
Jun 28 2016, 9:40 PM · Conduit, Arcanist, Bug Report
chad renamed T11222: arc hitting wrong url for conduit when not passed a full URI from arc hitting wrong url for conduit when not passed a full RUI to arc hitting wrong url for conduit when not passed a full URI.
Jun 28 2016, 8:16 PM · Conduit, Arcanist, Bug Report
chad renamed T11222: arc hitting wrong url for conduit when not passed a full URI from arc hitting wrong url for conduit when port in resource name after update to arc hitting wrong url for conduit when not passed a full RUI.
Jun 28 2016, 8:13 PM · Conduit, Arcanist, Bug Report
avivey added a parent task for T11223: 404 site after Terminate Conduit API key: T11098: Feedback and Errata for Global Settings.
Jun 28 2016, 5:02 PM · User Preferences, Bug Report
• bjorngi created T11223: 404 site after Terminate Conduit API key.
Jun 28 2016, 4:31 PM · User Preferences, Bug Report
chad added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

8bb124c37de3dfa29fcd23d4be53a5696b705c81 seems most likely root cause. I can trace it down to ssh coming in from getProtocol which should be blank and give you an error.

Jun 28 2016, 3:51 AM · Conduit, Arcanist, Bug Report
• sshannin added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

I'm not sure what to do with your link. Here's what I can reproduce:

Jun 28 2016, 3:50 AM · Conduit, Arcanist, Bug Report
chad added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

It should be erroring out that you're not putting in a valid URI.

Jun 28 2016, 3:41 AM · Conduit, Arcanist, Bug Report
• sshannin added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

Stock arcanist:

Jun 28 2016, 3:34 AM · Conduit, Arcanist, Bug Report
• sshannin added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.
Jun 28 2016, 3:21 AM · Conduit, Arcanist, Bug Report
chad added a comment to T11222: arc hitting wrong url for conduit when not passed a full URI.

Bug Reports require reproduction steps.

Jun 28 2016, 3:09 AM · Conduit, Arcanist, Bug Report
• sshannin created T11222: arc hitting wrong url for conduit when not passed a full URI.
Jun 28 2016, 3:02 AM · Conduit, Arcanist, Bug Report

Jun 22 2016

eadler moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 22 2016, 3:14 PM · Dashboards, Restricted Project, Conduit, Feature Request

Jun 17 2016

eadler moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2016, 7:08 AM · Restricted Project, Conduit, Arcanist, Diffusion
eadler added a project to T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist: Restricted Project.
Jun 17 2016, 6:55 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley closed T10512: Implement `user.search` Conduit API method as Resolved.

Appears resolved and accounted for.

Jun 17 2016, 2:02 AM · Prioritized, Restricted Project, People, Conduit, Feature Request

Jun 9 2016

epriestley closed T11123: Implement differential.revision.search as Resolved.

Sounds good. I'll call this done for now, let us know if you run into issues.

Jun 9 2016, 5:39 PM · Conduit, Differential, Feature Request
timhirsh added a comment to T11123: Implement differential.revision.search.

I was able to filter by status using the queryKey, which is much more valuable than displaying the status. So omitting status from the response is ok by me considering the level of effort required to refactor the numeric constants. Thanks again, much appreciated!

Jun 9 2016, 4:55 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11123: Implement differential.revision.search.

I return the other fields, but don't currently return "status" because I'd have to return an internal numeric constant. So we may need to fix that more thoroughly before you can move forward.

Jun 9 2016, 4:25 PM · Conduit, Differential, Feature Request
timhirsh added a comment to T11123: Implement differential.revision.search.

Awesome, thanks for the quick turnaround. This looks good to me. Currently I'm using revision ID, title, status, and authorPHID in the response for display purposes. I'll try your recommendation for 'open' revisions using the queryKey to handle the status.

Jun 9 2016, 4:20 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11123: Implement differential.revision.search.

Actually, this is slightly more involved because you want to select open revisions.

Jun 9 2016, 4:07 PM · Conduit, Differential, Feature Request
epriestley added a revision to T11123: Implement differential.revision.search: Restricted Differential Revision.
Jun 9 2016, 4:02 PM · Conduit, Differential, Feature Request
epriestley added a comment to T11123: Implement differential.revision.search.

You essentially only need the revision IDs in the response, right?

Jun 9 2016, 3:55 PM · Conduit, Differential, Feature Request
epriestley renamed T11123: Implement differential.revision.search from Search for revisions by project via conduit to Implement differential.revision.search.
Jun 9 2016, 3:51 PM · Conduit, Differential, Feature Request

Jun 6 2016

eadler edited projects for T9766: Expose conduit API to activate/disable Herald rules, added: Restricted Project; removed Restricted Project.
Jun 6 2016, 5:35 PM · Restricted Project, Restricted Project, Conduit, Herald

May 31 2016

avivey added a comment to T11052: projects.add_ transaction adds no project tag using conduit with maniphest edit.

Which instructions did you follow that included a key called value_add? These instructions were wrong and should be updated.

May 31 2016, 5:31 PM · Conduit, Bug Report
chad closed T11065: TEST_5 as Invalid.
May 31 2016, 2:23 PM · Conduit
chad closed T11062: TEST_3 as Invalid.
May 31 2016, 2:22 PM · Conduit
• PhabTab created T11065: TEST_5.
May 31 2016, 2:22 PM · Conduit
chad created T11062: TEST_3.
May 31 2016, 1:58 PM · Conduit
• PhabTab added a comment to T11052: projects.add_ transaction adds no project tag using conduit with maniphest edit.
[       {         "type": "title",         "value": "TEST_3"       },     {       "type": "description",       "value": "Test 3?"     },     {       "type": "owner",       "value": "PHID-USER-y7djwtvdkrc7sd2dymn6"     },     {       "type": "status",       "value": "open"     },     {       "type": "priority",       "value": "0"     },     {       "type": "projects.add",       "value_add": "PHID-PROJ-nitxwme6cvo45mcfry4s"      }   ]
May 31 2016, 1:34 PM · Conduit, Bug Report

May 28 2016

chad closed T11052: projects.add_ transaction adds no project tag using conduit with maniphest edit as Invalid.
May 28 2016, 11:17 PM · Conduit, Bug Report
avivey added a comment to T11052: projects.add_ transaction adds no project tag using conduit with maniphest edit.

I can't reproduce this; I've used conduit to add the "Conduit" project to this task:

pasted_file (557×410 px, 32 KB)

May 28 2016, 8:53 PM · Conduit, Bug Report
avivey added a project to T11052: projects.add_ transaction adds no project tag using conduit with maniphest edit: Conduit.
May 28 2016, 8:50 PM · Conduit, Bug Report

May 26 2016

mavit added a comment to Q404: Find a unique identifier for a Diffusion repository from a Git repository?.

The trouble is that that could sometimes give the wrong answer, because querying the Git URI is not the only way that arc itself finds the repository; for example, the repository callsign can be hardcoded into .arcconfig.

May 26 2016, 9:40 PM · Conduit, Diffusion
avivey added a comment to Q404: Find a unique identifier for a Diffusion repository from a Git repository?.

I think the only way right now is to get the remote uri, call repository.query with it, and parse that.
It might make sense to just teach arc which to output it's things in json.

May 26 2016, 8:15 PM · Conduit, Diffusion
mavit updated Q404: Find a unique identifier for a Diffusion repository from a Git repository? from to Find a unique identifier for a Diffusion repository from a Git repository?.
May 26 2016, 7:42 PM · Conduit, Diffusion